Add piuparts-report linktarget_by_template information to known_probl…

…ems.

...by adding a PRIORITY field to all known problem conf files,
capturing the order of entries in linktarget_by_template, and an
EXPLAIN field with the description text.

known_problems/alternatives_after_purge_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with unowned files in /etc/alternatives after purge (policy 6.8)
 #
+EXPLAIN='due to forgotten alternatives after purge'
+PRIORITY=180
 PATTERN='/etc/alternatives/.*not owned'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/alternatives_after_purge_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with unowned files in /etc/alternatives after purge (policy 6.8)
 #
+EXPLAIN='but logfile contains forgotten alternatives'
+PRIORITY=40
 PATTERN='/etc/alternatives/.*not owned'
 WHERE='pass'
 ISSUE=1

known_problems/broken_symlinks_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which have the string "Broken symlinks" in their logs
 #
+EXPLAIN='...and logfile also contains 'broken symlinks''
+PRIORITY=400
 PATTERN='(WARN|FAIL): Broken symlink'
 WHERE='fail bugged affected'
 ISSUE=1

known_problems/broken_symlinks_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which have the string "Broken symlinks" in their logs
 #
+EXPLAIN='but logfile contains 'broken symlinks''
+PRIORITY=90
 PATTERN='(WARN|FAIL): Broken symlink'
 WHERE='pass'
 ISSUE=1

known_problems/command_not_found_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with miss a depends or use non-essential in purge
 #
+EXPLAIN='due to a 'command not found' error'
+PRIORITY=140
 PATTERN='command not found|: not found'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/command_not_found_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which passed the piuparts test but have the string "command not found" in their logs
 #
+EXPLAIN='but logfile contains 'command not found''
+PRIORITY=20
 PATTERN='command not found|: not found'
 WHERE='pass'
 ISSUE=1

known_problems/conffile_prompt_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with failed because they prompt due to a modified conffile
 #
+EXPLAIN='due to prompting due to modified conffiles'
+PRIORITY=270
 PATTERN='EOF on stdin at conffile prompt'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/cron_error_after_removal_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with cron errors after the package has been removed
 #
+EXPLAIN='due to errors from cronjob after removal'
+PRIORITY=370
 PATTERN='(FAIL: Cron file .* has output with package removed|ERROR: Command failed.*./etc/cron\..*/.*.])'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/db_setup_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with failed to install due to problems configuring the db - see #595652
 #
+EXPLAIN='due to failing to setup a database'
+PRIORITY=280
 PATTERN='(warning: database package not installed|dbconfig-common: .* configure: (aborted|noninteractive fail).|updating database schema for .*...command failed with code 0|psql: could not connect to server: No such file or directory|DBI connect.* failed: could not connect to server|pg_pconnect\(\): Unable to connect to PostgreSQL server|Unable to connect to MySQL server|unable to connect to mysql server)'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/db_setup_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with failed to install due to problems configuring the db - see #595652
 #
+EXPLAIN="but logfile contains failure to setup a database"
+PRIORITY=75
 PATTERN='(warning: database package not installed|dbconfig-common: .* configure: (aborted|noninteractive fail).|updating database schema for .*...command failed with code 0|psql: could not connect to server: No such file or directory|DBI connect.* failed: could not connect to server|pg_pconnect\(\): Unable to connect to PostgreSQL server|Unable to connect to MySQL server|unable to connect to mysql server)'
 WHERE='pass'
 ISSUE=1

known_problems/debsums_mismatch_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which modify shipped files
 #
+EXPLAIN='due to modifying conffiles or other shipped files'
+PRIORITY=170
 PATTERN='FAIL: debsums reports modifications inside the chroot'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/debsums_mismatch_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which modify shipped files
 #
+EXPLAIN='but logfile contains modified conffiles or other shipped files'
+PRIORITY=30
 PATTERN='FAIL: debsums reports modifications inside the chroot'
 WHERE='pass'
 ISSUE=1

known_problems/dependency_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with unsatisfied dependencies
 #
+EXPLAIN='due to unsatisfied dependencies'
+PRIORITY=120
 PATTERN='E: Broken packages|E: Unable to correct problems, you have held broken packages.|E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/disappeared_files_after_purge_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with disappeared files after purge
 #
+EXPLAIN='due to files having disappeared after purge'
+PRIORITY=230
 PATTERN='FAIL: After purging files have disappeared:'
 EXCLUDE_PATTERN=',|usr/local'
 WHERE='fail bugged affected'

known_problems/diversion_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which mishandle diversions
 #
+EXPLAIN='due to diversions being modified after purge'
+PRIORITY=240
 PATTERN='ERROR: FAIL: (Existing|Installed) diversions'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/files_in_usr_local_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which leave stuff in /usr/local (see policy 9.1.2)
 #
+EXPLAIN='due to files in /usr/local'
+PRIORITY=150
 PATTERN='usr/local.+not owned'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/initdscript_lsb_header_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with an update-rc.d warning
 #
+EXPLAIN='but logfile contains update-rc.d issues'
+PRIORITY=10
 PATTERN='update-rc.d: warning.*do not match LSB'
 WHERE='fail bugged affected pass'
 ISSUE=1

known_problems/insserv_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with fail due to insserv error
 #
+EXPLAIN='due to a problem with insserv'
+PRIORITY=290
 PATTERN='insserv: exiting now'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/installs_over_symlink_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which have the string "dirname part contains a symlink" in their logs
 #
+EXPLAIN='...and package installs something over existing symlinks'
+PRIORITY=390
 PATTERN='silently overwrites files via directory symlinks|dirname part contains a symlink'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/installs_over_symlink_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which have the string "dirname part contains a symlink" in their logs
 #
+EXPLAIN='but package installs something over existing symlinks'
+PRIORITY=80
 PATTERN='silently overwrites files via directory symlinks|dirname part contains a symlink'
 WHERE='pass'
 ISSUE=1

known_problems/logrotate_error_after_removal_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with logrotate errors after the package has been removed
 #
+EXPLAIN='due to errors from logrotate after removal'
+PRIORITY=380
 PATTERN='(FAIL: Logrotate file .* has output with package removed|ERROR: Command failed.*'/etc/logrotate\.d/.*'])'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/maintainer_script_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages in successfully-tested state that had maintainer script failures
 #
+EXPLAIN='but logfile contains maintainer script failures'
+PRIORITY=70
 PATTERN='subprocess .*(pre|post)-(installation|removal) script returned error'
 WHERE='pass'
 ISSUE=0

known_problems/modified_files_after_purge_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with modified files after purge
 #
+EXPLAIN='due to files having been modified after purge'
+PRIORITY=220
 PATTERN='FAIL: After purging files have been modified:'
 EXCLUDE_PATTERN=',|usr/local'
 WHERE='fail bugged affected'

known_problems/needs_rebuild_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which have the string "Please rebuild the package" or "package ... should be rebuilt" in their logs
 #
+EXPLAIN="but logfile recommends to rebuild some packages"
+PRIORITY=105
 PATTERN="Please rebuild the package|should be rebuilt|should be rebuild|warning: maintainer scripts should not call install-info anymore"
 WHERE='pass'
 ISSUE=1

known_problems/obsolete_conffiles_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages that leave obsolete conffiles after upgrades
 #
+EXPLAIN='...and logfile reports obsolete conffiles'
+PRIORITY=410
 PATTERN='OBSOLETE CONFFILE'
 WHERE='fail bugged affected'
 ISSUE=1

known_problems/obsolete_conffiles_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages that leave obsolete conffiles after upgrades
 #
+EXPLAIN='but logfile reports obsolete conffiles'
+PRIORITY=110
 PATTERN='OBSOLETE CONFFILE'
 WHERE='pass'
 ISSUE=1

known_problems/overwrite_other_packages_files_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which try to overwrite other packages files
 #
+EXPLAIN='due to overwriting other packages files'
+PRIORITY=160
 PATTERN='trying to overwrite (.*) which is also in package'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/owned_files_after_purge_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with owned files after purge (policy 6.8)
 #
+EXPLAIN='due to owned files existing after purge'
+PRIORITY=200
 PATTERN='owned by:'
 EXCLUDE_PATTERN=',|usr/local/'
 WHERE='fail bugged affected'

known_problems/owned_files_after_purge_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with owned files after purge (policy 6.8)
 #
+EXPLAIN='but logfile contains owned files existing after purge'
+PRIORITY=50
 PATTERN='owned by:'
 WHERE='pass'
 ISSUE=1

known_problems/owned_files_by_many_packages_error.conf

@@ -1,6 +1,8 @@
 #
 # detect conffiles owned by two or more packages which are not removed by dpkg correctly
 #
+EXPLAIN='due to owned files by many packages'
+PRIORITY=190
 PATTERN='owned by.+,'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/packages_have_been_kept_back_error.conf

@@ -1,6 +1,8 @@
 #
 # detect possible dependency issues
 #
+EXPLAIN='...and logfile also contains 'packages have been kept back''
+PRIORITY=130
 PATTERN='packages have been kept back'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/packages_have_been_kept_back_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect possible dependency issues
 #
+EXPLAIN='but logfile contains 'packages have been kept back''
+PRIORITY=100
 PATTERN='packages have been kept back'
 WHERE='pass'
 ISSUE=1

known_problems/post_installation_script_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which failed because post-installation maintainer script failed
 #
+EXPLAIN='due to post-installation maintainer script failed'
+PRIORITY=330
 PATTERN='subprocess .*post-installation script returned error'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/post_removal_script_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which failed because post-removal maintainer script failed
 #
+EXPLAIN='due to post-removal maintainer script failed'
+PRIORITY=350
 PATTERN='subprocess .*post-removal script returned error'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/pre_depends_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which failed because of a problem with pre-depends
 #
+EXPLAIN='due to a problem with pre-depends'
+PRIORITY=310
 PATTERN='E: Couldn.t configure pre-depend .* for .*, probably a dependency cycle.'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/pre_installation_script_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which failed because pre-installation maintainer script failed
 #
+EXPLAIN='due to pre-installation maintainer script failed'
+PRIORITY=320
 PATTERN='subprocess .*pre-installation script returned error'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/pre_removal_script_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which failed because pre-removal maintainer script failed
 #
+EXPLAIN='due to pre-removal maintainer script failed'
+PRIORITY=340
 PATTERN='subprocess .*pre-removal script returned error'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/problems_and_no_force_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with problems because of not enough force
 #
+EXPLAIN='due to not enough force being used'
+PRIORITY=300
 PATTERN='E: There are problems and -y was used without --force-yes'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/processes_running_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which failed because of processes are running inside chroot
 #
+EXPLAIN='due to leaving processes running behind'
+PRIORITY=250
 PATTERN='ERROR: FAIL: Processes are running inside chroot'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/resource_violation_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages violating resource limits during the test
 #
+EXPLAIN='due to resource violation'
+PRIORITY=260
 PATTERN='Command was terminated after exceeding|Process KILLED - exceed maximum run time'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/unknown_purge_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages which try to overwrite other packages files
 #
+EXPLAIN='due to purge failed due to an unknown reason'
+PRIORITY=360
 PATTERN='ERROR: Command failed .*.dpkg., .--purge., .--pending.]'
 WHERE='fail bugged affected'
 ISSUE=0

known_problems/unowned_files_after_purge_error.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with unowned files after purge (policy 6.8)
 #
+EXPLAIN='due to unowned files after purge'
+PRIORITY=210
 PATTERN='not owned'
 EXCLUDE_PATTERN='/usr/share/mime/|usr/local/'
 WHERE='fail bugged affected'

known_problems/unowned_files_after_purge_issue.conf

@@ -1,6 +1,8 @@
 #
 # detect packages with unowned files after purge (policy 6.8)
 #
+EXPLAIN='but logfile contains unowned files after purge'
+PRIORITY=60
 PATTERN='not owned'
 EXCLUDE_PATTERN="/usr/share/mime/|usr/local/"
 WHERE='pass'