Fix gem build licence warning #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davetron5000
reviewed
Nov 2, 2016
| @@ -69,7 +69,7 @@ main do |app_name| | |||
| if gemspec_content =~ /(^\s*#{gem_variable}\.license\s*=\s*).*/ | |||
| gemspec_content.gsub!(/(^\s*#{gem_variable}\.license\s*=\s*).*/,"\\1#{license.to_s.inspect}") | |||
| else | |||
| gemspec_content.gsub!(/(^\s*#{gem_variable}\.name\s*=\s*.*)/,"\\1\n #{gem_variable}.license=#{license.to_s.inspect}") | |||
| gemspec_content.gsub!(/(^\s*#{gem_variable}\.name\s*=\s*.*)/,"\\1\n#{" #{gem_variable}.license".ljust(20)} = #{license.to_s.inspect.upcase}") | |||
There was a problem hiding this comment.
@CrCs2O4 what is the ljust for here?
There was a problem hiding this comment.
ljust align license string with others
Before PR:
After PR:
|
d'oh. thanks for finding this! |
|
@davetron5000 you need something more from me to merge this PR? |
|
Released as https://github.com/davetron5000/methadone/releases/tag/v1.9.3 Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building gem created with Methadone there is a warning:
Thanks for awesome app!