Merge pull request #17 from davewalker5/FR-24-Bug-Fixes #105
davewalker5Annotations
11 warnings
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, actions/setup-java@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build:
src/FlightRecorder.Entities/Db/JobStatus.cs#L9
Remove this empty class, write its code or make it an "interface".
|
|
build:
src/FlightRecorder.BusinessLogic/Logic/SightingManager.cs#L105
Remove this commented out code.
|
|
build:
src/FlightRecorder.DataExchange/AirportExporter.cs#L21
Make this field 'private' and encapsulate it in a 'public' property.
|
|
build:
src/FlightRecorder.DataExchange/CsvExporter.cs#L30
Make this field 'private' and encapsulate it in a 'public' property.
|
|
build:
src/FlightRecorder.DataExchange/CsvImporter.cs#L17
Make this field 'private' and encapsulate it in a 'public' property.
|
|
build:
src/FlightRecorder.DataExchange/AirportImporter.cs#L18
Make this field 'private' and encapsulate it in a 'public' property.
|
|
build:
src/FlightRecorder.DataExchange/AirportImporter.cs#L27
Pass a timeout to limit the execution time.
|
|
build:
src/FlightRecorder.DataExchange/CsvImporter.cs#L26
Pass a timeout to limit the execution time.
|
|
build:
src/FlightRecorder.Entities/Db/JobStatus.cs#L9
Remove this empty class, write its code or make it an "interface".
|
|
build:
src/FlightRecorder.BusinessLogic/Logic/SightingManager.cs#L105
Remove this commented out code.
|