Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log level implementation incomplete? #296

Closed
hk05 opened this issue Feb 1, 2020 · 2 comments
Closed

log level implementation incomplete? #296

hk05 opened this issue Feb 1, 2020 · 2 comments
Assignees
@DaveWoodCom

Comments

@hk05
Copy link

hk05 commented Feb 1, 2020

The readme gives the impression that one can use the new log levels log.alert("something"), lag.notice("something") and log.severe("something") in a way similar to the other log levels (e.g. log.debug et al).

The methods from the readme/Basic Usage (Quick Start) cannot be used (for example: "log.notice("A notice message")" results in a compiler error). In the source code I can see that the log levels have been implemented, but not the functions.

I assume that the implementation is not complete yet? Or is it supposed to be used in a different way (in which case the readme is confusing).
@DaveWoodCom
Copy link
Owner

@hk05 You're correct. No idea how I missed that. Will update shortly. Thanks for pointing this out.

@DaveWoodCom DaveWoodCom self-assigned this Feb 3, 2020
@DaveWoodCom
Copy link
Owner

Fixed in 7.0.1 Thanks again.

DaveWoodCom added a commit that referenced this issue Feb 4, 2020
@DaveWoodCom
Add missing convenience methods for the new log levels (thanks @hk05, f…
733be70 
…ixes #296)
b-yng pushed a commit to b-yng/XCGLogger that referenced this issue Feb 5, 2021
@b-yng2
Merge remote-tracking branch 'upstream/master'
842972b 
* upstream/master:
  Version bump 7.0.1
  Xcode 11.3.1 project updates
  Adds new log levels to the demo projects
  Add missing convenience methods for the new log levels (thanks @hk05, fixes DaveWoodCom#296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaveWoodCom DaveWoodCom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DaveWoodCom @hk05