Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around monorepos #134

Closed
honzajavorek opened this issue Jan 18, 2018 · 2 comments
Closed

Work around monorepos #134

honzajavorek opened this issue Jan 18, 2018 · 2 comments

Comments

@honzajavorek
Copy link
Contributor

There is a common issue with monorepos, described in lerna/lerna#1213. Would it make sense for license checker to work around the issue? It could somehow check whether the project is/isn't a monorepo and in case the license is missing, it could look it up in the root of the monorepo.

@davglass
Copy link
Owner

Not sure what you expect this module to do. It scans the installed packages, it never looks outside of the installed path for anything. So it couldn't check the root of a monorepo since it never leaves the disk. If the package doesn't ship with a license in the source, then it's not technically licensed properly.

@honzajavorek
Copy link
Contributor Author

Hmm, I guess you're right. This really needs to be fixed with the projects and the tooling around monorepos 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants