Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using augmented assignment statements #3

Closed
elfring opened this issue Feb 24, 2019 · 6 comments
Closed

Using augmented assignment statements #3

elfring opened this issue Feb 24, 2019 · 6 comments

Comments

@elfring
Copy link
Contributor

elfring commented Feb 24, 2019

I have noticed that source code like “var = var + X” was specified at a few places so far.
I suggest to use augmented assignment statements instead.

@david-a-wheeler
Copy link
Owner

I will take patches, but I'll note that the amount of performance gained really isn't worth the trouble. What is more important is improving its ability to detect real problems or to ignore false positives.

@elfring
Copy link
Contributor Author

elfring commented Feb 24, 2019

  • Would you like to apply another regular expression for the proposed software transformation?
  • I find that source code analysis approaches from this Python script point fundamental open issues out in comparison to other known software technology.

@david-a-wheeler
Copy link
Owner

david-a-wheeler commented Feb 24, 2019

I'm not sure what you mean. If you'd like to propose a change to the software, then create a pull request with the proposed change.

@elfring
Copy link
Contributor Author

elfring commented Feb 25, 2019

@david-a-wheeler
Copy link
Owner

Pull request #4 changes flawfinder to use augmented assignment statements.

@david-a-wheeler
Copy link
Owner

The changes were merged, I'm closing this matching issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants