Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing the use of the TkAgg Matplot lib backend prevents usage in notebooks #40

Open
philwinder opened this issue Jul 1, 2019 · 1 comment

Comments

@philwinder
Copy link

commented Jul 1, 2019

Hi there. In a few places you force the use of TkAgg. In the past this was necessary to work on certain systems, but I believe this is no longer the case with newer versions of Matplotlib.

However, forcing TkAgg breaks the code on, for example, Google Colab.

I see it was introduced in this commit: e089dd9

I think the easiest solution is to revert that commit and test again on the original system that was having issues (probably OSX).

Here is the most simple reproduction: https://colab.research.google.com/gist/philwinder/148a4a54d0a7fdc1a10677f30da2da57/untitled6.ipynb

This:

!pip install simple_rl
from simple_rl.tasks import GridWorldMDP

Thanks!

@david-abel

This comment has been minimized.

Copy link
Owner

commented Aug 7, 2019

Yes, indeed the TkAgg backend was being used to fix some issues on OSX. I will test taking TkAgg out, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.