Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New info extracted from your library #8

Closed
traponto opened this issue Sep 10, 2018 · 10 comments
Closed

New info extracted from your library #8

traponto opened this issue Sep 10, 2018 · 10 comments

Comments

@traponto
Copy link

Hi, I wanted to ask if you were willing to integrate some information that I found in the DiscoGS DB and that are not currently extracted from your library.

For now I can not give you a precise list (in testing my applications sometimes I find something) but for now I could give you two / three that I found.

Thanks in advance,
   Traponto

@David-Desmaisons
Copy link
Owner

@traponto , yes I will maintain and improve this library.
Ideally what you can do is to provide the missing properties, their respective types, the corresponding documentation and an url example returning this kind of information.
PR are also very welcomed.

@traponto
Copy link
Author

I
alljson.zip
n the Release structure I do not find the properties "series" and "artists_sort".

The first (series) should have the same structure related to "labels". An example can be found in file 2221110.json included in the attached compressed file.

The second (artists_sort) should be of string type and in every attached json file you can find an example, what I think is more significant is the one present in 3340518.json

From what I have seen these two properties are always present even if not used (in this case they are empty)

In the Format structure, I do not find the "text" property (string type). You can find two examples in the 9898418.json and 3041685.json files. In this case the property is not always present.

I hope I have provided the information clearly.

"PR are also very welcomed" ... what do you mean by PR?

@David-Desmaisons
Copy link
Owner

@traponto Pull Request

@David-Desmaisons
Copy link
Owner

What are the corresponding request urls?

@traponto
Copy link
Author

if you mean this information:
https://api.discogs.com/releases/9898418
https://api.discogs.com/releases/3041685
https://api.discogs.com/releases/2221110
https://api.discogs.com/releases/3340518

then in the compressed file I sent you should find a .txt file that contains them

@traponto
Copy link
Author

As a NuGet package I'm using DiscogsClient version 2.2.0. I see the update 2.2.1 is present but refers to adjustments made in June. Will you publish a new version?

@David-Desmaisons
Copy link
Owner

I just released version 2.3.0

@traponto
Copy link
Author

I installed the update through NuGet, I see that other packages are updated and among these there is also System.Reactive 4.0.0, is that right? Now I have an error in the compilation phase at the instructions:

var observable = DiscogsClient.Search (discogsSearch);
await observable.ForEachAsync (OnResult);

Upd_msg_and_err.zip

@David-Desmaisons
Copy link
Owner

You have to remove the references to all the Rx.XXX nuget packages that have been substitued by System.Reactive.

@traponto
Copy link
Author

now the compilation is OK

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants