Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments from a squirrel #2

Closed
jhong93 opened this issue Feb 23, 2022 · 2 comments
Closed

Comments from a squirrel #2

jhong93 opened this issue Feb 23, 2022 · 2 comments

Comments

@jhong93
Copy link

jhong93 commented Feb 23, 2022

L119: Change to AdamW or Adam (less need to tune LR)

L85: no relus after final layer

L95: check docs to see if you are applying softmax twice by accident from nn.CrossEntropy

cross_entropy and cross_entropy_with_logits (check L119)
https://pytorch.org/docs/stable/generated/torch.nn.CrossEntropyLoss.html

loss_fn = nn.CrossEntropyLoss()

@David-Durst
Copy link
Owner

L119: changed. do I need to set any parameters? Or are the defaults all good?

L85: fixed

L95: I was, fixed

@David-Durst
Copy link
Owner

I notice that Adam gets the same test set avg loss after epoch 1 as SGD gets after epoch 5, but Adam never improves during epochs 2-5. I guess my loss is so small (0.04) that there's nothing more to learn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants