-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing vimium features #45
Comments
Scroll is implemented with |
Ideally you could give a float as a second parameter. That way the user could configure their own scroll levels and even have a rule with a number in it for custom scrolling. If we are talking about fixed levels then half the page is what vimium uses and I find that very useful. upper and downer followed by a target I have found but how do you center on a target? upper and downer also works a bit weird for me. Sometimes the target is outside of the viewport and if you issue it on the same target again you don't get the same result. I don't have a page in mind but you could easily build a jsfiddle to test with. |
Centering is still not released but you can see how it will work here: #3 (comment) You can use |
I guess it's not trivial to fix so upper/downer doesn't overshoot like that? |
What do you mean overshoot? I can make scroll be the amount that I want. I can implement the float as a second parameter that you mention, it's no problem. |
I mean |
I think you're misunderstanding what the goal of that command is. The goal is to be able to scroll a scroll container that otherwise is not reachable by voice. So the target is just a way to reference that container, it is not meant to just scroll the element up and down and stop when the element is about to disappear from the viewport. Let me know if you're not well served with the way these scroll commands work and we'll see what can we do about that. Implementing the behavior that you mention is possible, maybe passing an argument like |
Okay I guess my confusion is because there is no commands called crown and bottom in my code. I guess it's not released yet? The only thing I would like is for the scroll amount to be configurable via a parameter in the api |
Yes, crown, bottom and center are still not released. I will add a parameter to configure the scroll amount |
Thanks! :) |
Do you have any suggestion for words for scroll left and right? |
For opening in a new window I thought of I also need one for visitPreviousTab. BTW, would this command cycle between two tabs or would it move back and forth through the tabs in order of last visited. Maybe we could have commands for both |
These are the commands I used today
The vimium implementation is just swapping between the last two. I do agree that both are probably useful and if you could implement both as separate commands that will be great. |
|
I also have some Vimium commands I use quite often which could be handy
Of course all these can currently be done by clicking rango hints, but I find that I do these often enough that being able to skip reading/speaking letters is valuable |
All those seem useful and easy to implement . I will try to have them ready for the next release. |
I implemented the rest of the features, but I somehow missed |
I would like to completely replace vimium with rango, but there is some features I still use that are vimium explicit.
The text was updated successfully, but these errors were encountered: