Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warden should use physical vs logical working dictory with docker-compose #101

Closed
davidalger opened this issue Feb 17, 2020 · 0 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@davidalger
Copy link
Collaborator

Docker for Desktop v2.2.0.0 changed the way File Sharing paths can be specified and no longer allows entering a path manually. Using the file browser to select a directory to share a symlinked location resolves the symlink, making it thus impossible to share a location using the symlinked path.

This change in docker causes problems when using /sites/exampleproject to run warden env ... commands and where /sites is a symlink resolving to (for example) /Volumes/Server/sites.

Resolution to this should be simple changing use of pwd to pwd -P in order to enforce uniform use of the physical location.

Effects of this change

a) Output of warden env config will use physical paths in volume mount points as docker-compose will be executed using the physical path of (based on example above) of /Volumes/Server/sites/exampleproject rather than /sites/exampleproject

b) Users with only /sites exported in File Sharing preferences will need to share the correct physical location of /Volumes/Server/sites instead

c) It will no longer matter which working directory warden is run from (i.e. /sites vs /Volumes/Server/sites) as they both will operate identically (using the latter of the two in this case)

Example from File Sharing preferences in new Docker Desktop version:

@davidalger davidalger added the enhancement New feature or request label Feb 17, 2020
@davidalger davidalger added this to the Warden 0.2.4 milestone Feb 17, 2020
@davidalger davidalger self-assigned this Feb 17, 2020
@davidalger davidalger added bug Something isn't working and removed enhancement New feature or request labels Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant