Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warden does not enforce lowercase when dealing with network names #127

Closed
jkenneydaniel opened this issue Mar 24, 2020 · 1 comment
Closed
Labels
bug Something isn't working
Milestone

Comments

@jkenneydaniel
Copy link

I ran into an issue after upgrading to V0.3 that was not previously an issue after the changes to Traefik and Tunnel. My .env file leveraged WARDEN_ENV_NAME=ProjectNameHere which created issues when trying to stand up my environment. Changing WARDEN_ENV_NAME to projectnamehere matched the network name created by Docker (as it enforces lowercase) and fixed the issue.

@davidalger davidalger added the bug Something isn't working label Mar 24, 2020
@davidalger davidalger added this to the Warden 0.4.0 milestone Mar 26, 2020
@davidalger
Copy link
Collaborator

Tested up/down on macOS after implementing this using WARDEN_ENV_NAME=Examp_le3-Project in a project .env file:

davidalger:05:34 PM:/sites/m2template (develop *) $ warden env up -d
Creating network "examp_le3-project_default" with the default driver
Creating volume "examp_le3-project_dbdata" with default driver
Creating volume "examp_le3-project_esdata" with default driver
Creating volume "examp_le3-project_appdata" with default driver
Creating examp_le3-project_rabbitmq_1      ... done
Creating examp_le3-project_elasticsearch_1 ... done
Creating examp_le3-project_mailhog_1       ... done
Creating examp_le3-project_db_1            ... done
Creating examp_le3-project_redis_1         ... done
Creating examp_le3-project_php-fpm_1       ... done
Creating examp_le3-project_php-debug_1     ... done
Creating examp_le3-project_nginx_1         ... done
Creating examp_le3-project_varnish_1       ... done
Connecting traefik to examp_le3-project_default network
Connecting tunnel to examp_le3-project_default network
Starting examp_le3-project_mailhog_1       ... done
Starting examp_le3-project_redis_1         ... done
Starting examp_le3-project_elasticsearch_1 ... done
Starting examp_le3-project_rabbitmq_1      ... done
Starting examp_le3-project_db_1            ... done
Recreating examp_le3-project_php-fpm_1     ... done
Recreating examp_le3-project_nginx_1       ... done
Recreating examp_le3-project_php-debug_1   ... done
Recreating examp_le3-project_varnish_1     ... done
Created session sync_BSGfPlwB130dlD6rGAIJj9FzqvhseIoJWHprOklKdn3                
Waiting for initial synchronization to complete

davidalger:05:34 PM:/sites/m2template (develop *) $ warden env down -v
Disconnecting traefik from examp_le3-project_default network
Disconnecting tunnel from examp_le3-project_default network
Stopping examp_le3-project_varnish_1       ... done
Stopping examp_le3-project_nginx_1         ... done
Stopping examp_le3-project_php-debug_1     ... done
Stopping examp_le3-project_php-fpm_1       ... done
Stopping examp_le3-project_rabbitmq_1      ... done
Stopping examp_le3-project_mailhog_1       ... done
Stopping examp_le3-project_db_1            ... done
Stopping examp_le3-project_elasticsearch_1 ... done
Stopping examp_le3-project_redis_1         ... done
Removing examp_le3-project_varnish_1       ... done
Removing examp_le3-project_nginx_1         ... done
Removing examp_le3-project_php-debug_1     ... done
Removing examp_le3-project_php-fpm_1       ... done
Removing examp_le3-project_rabbitmq_1      ... done
Removing examp_le3-project_mailhog_1       ... done
Removing examp_le3-project_db_1            ... done
Removing examp_le3-project_elasticsearch_1 ... done
Removing examp_le3-project_redis_1         ... done
Removing network examp_le3-project_default
Removing volume examp_le3-project_dbdata
Removing volume examp_le3-project_esdata
Removing volume examp_le3-project_appdata

Successfully executes now regardless of uppercase chars being present in env name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants