Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change selenium environment include to use hub/node configuration #67

Closed
davidalger opened this issue Jan 8, 2020 · 2 comments
Closed
Labels
enhancement New feature or request
Milestone

Comments

@davidalger
Copy link
Collaborator

As configured currently selenium is using an all-in-one container, this would preclude multi-browser testing. Would like to see something like the following (i.e. hub and a chrome node) supported OOTB here (allowing environments to add additional nodes as needed).

  selenium-hub:
    container_name: ${WARDEN_ENV_NAME}_selenium-hub
    image: selenium/hub:3.141.59-titanium
    ports:
      - "4444:4444"
  selenium-chrome:
    container_name: ${WARDEN_ENV_NAME}_chrome
    image: selenium/node-chrome:3.141.59-titanium
    volumes:
      - /dev/shm:/dev/shm
    depends_on:
      - selenium-hub
    environment:
      - HUB_HOST=selenium-hub
      - HUB_PORT=4444
      - START_XVFB=false

Note this will require reform before dropping into place as it came from a sidecar stack.

cc @lbajsarowicz would be wonderful if you'd like to tackle this since you've got a working MFTM setup you could validate the changes with, otherwise I'll probably tackle it only if I have the time leading up to Warden 0.2.0 release.

@davidalger davidalger added the enhancement New feature or request label Jan 8, 2020
@davidalger davidalger added this to the Warden 0.2.0 milestone Jan 8, 2020
@lbajsarowicz
Copy link
Contributor

Good point, but we need to take into consideration the fact that Codeception is not supporting Selenium that is more recent than 3.8.1. What is more - I'd like to give choice to use DEBUG version (that can be connected with VNC), not only -titanum one without possibility to check what's wrong.

@lbajsarowicz
Copy link
Contributor

Another point is... Allure reporting. We should be able to provide interface - for example allure.{domain}.test

lbajsarowicz added a commit to lbajsarowicz/warden that referenced this issue Jan 8, 2020
lbajsarowicz added a commit to lbajsarowicz/warden that referenced this issue Jan 8, 2020
davidalger pushed a commit to lbajsarowicz/warden that referenced this issue Jan 24, 2020
davidalger pushed a commit to lbajsarowicz/warden that referenced this issue Jan 24, 2020
davidalger pushed a commit to lbajsarowicz/warden that referenced this issue Jan 24, 2020
davidalger added a commit that referenced this issue Jan 24, 2020
* #67 Add `selenium-hub` support. Extend documentation.

* #67 Add `selenium-hub` support. Extend documentation.

* #67 Add Allure reports

* Updated debug container switching to simply use a variable passed through to the template; updated CL

* Updated CL

* Added rules @lbajsarowicz passed me for allure api; adding with TODO

Co-authored-by: David Alger <davidmalger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants