Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutagen syncs should be automatically started and stopped as needed #90

Closed
davidalger opened this issue Feb 8, 2020 · 1 comment
Closed
Labels
enhancement New feature or request
Milestone

Comments

@davidalger
Copy link
Collaborator

On macOS (darwin) for environments that utilize Mutagen sync sessions (currently only magento2 environments leverage them, although I expect this to extend to other types fairly soon) sync should automatically start and stop when the user runs env start, env stop, up and down. This should also resolve issues caused where env up -d is run re-creating php-fpm containers breaking the sync session, as the operation would then be followed by re-creating the sync session rather than counting on the user to do so manually. Implementation of this should be such that running a start or up command does not re-create the sync session if one already exists (unless it’s broken, indicating container was re-created)

@davidalger davidalger added the enhancement New feature or request label Feb 13, 2020
@davidalger davidalger added this to the Warden 0.3.0 milestone Feb 13, 2020
@davidalger
Copy link
Collaborator Author

Template init.sh script has also been updated, so as long as the latest init.sh script is on a project when 0.3.0 is released, the script will only call sync start directly on versions of Warden older than 0.3.0:
wardenenv/warden-env-magento2@b3f6ad6

davidalger added a commit that referenced this issue Mar 6, 2020
davidalger added a commit that referenced this issue Mar 7, 2020
…n env types not using Mutagen sessions

Due to changes made to implement #90 failing to account for env types not using sync sessions, these commands would exit with the following error and a non-zero exit code:

Mutagen configuration does not exist for environment type "magento1"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant