Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Symfony 4+ #146

Merged
merged 1 commit into from
May 21, 2020

Conversation

lbajsarowicz
Copy link
Contributor

This PR adds the skeleton to run Symfony 4+ on Warden OOTB.
Due to the fact that Symfony uses .env file, too - I used WEBROOT with value of web/ by default

@davidalger
Copy link
Collaborator

@lbajsarowicz Thanks for this! I'll be pushing a similarly named branch to this repo with this work merged into the feature/environment-template-restructure branch where I'm working on the implementation outlined here (which is for the 0.5.0 release): #105 (comment)

Few points of feedback:

  • We can't use an appdata volume on the macOS side unless there is a Mutagen configuration for Symfony in place. I'll be stripping that out to use a delgated mount on macOS similar to Laravel and Magento 1 types (these may all eventually get Mutagen configurations if there is reason and request for it)
  • I'll be removing the custom set of WARDEN_WEB_ROOT; understand the reasoning behind that note, but at this point I'm not ready to have new environments use a custom webroot location (docs would need to be updated, and I'd want it to be uniform across all env types should this take place, reason here being the intent is to have it be really easy to add a warden configuration to an existing project) - I do understand this currently poses a challenge with committing the .env for Warden but want to take this one step at a time.

Once I finish the work on https://github.com/davidalger/warden/tree/feature/environment-template-restructure I'll merge https://github.com/davidalger/warden/tree/feature/symfony-support into develop as well, and when I do that, this PR will close. I can't update the branch on your repo due to permissions, so if you want to test the integrated work ahead of time, feel free to poke at that branch prior to it being merged (it probably won't be until next week after I'm back from vacation)

@davidalger davidalger added the enhancement New feature or request label May 14, 2020
@davidalger davidalger added this to the Warden 0.5.0 milestone May 14, 2020
@davidalger
Copy link
Collaborator

To compare feature/symfony-support against new base feature/environment-template-restructure branch go here: https://github.com/davidalger/warden/compare/feature/environment-template-restructure..feature/symfony-support

davidalger added a commit that referenced this pull request May 14, 2020
@davidalger davidalger merged commit f055d70 into wardenenv:develop May 21, 2020
@davidalger
Copy link
Collaborator

Added note regarding new Symfony env type on this docs page: https://docs.warden.dev/environments/types.html

Thanks for the contribution @lbajsarowicz

@davidalger davidalger linked an issue Jun 2, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup base environment for Symfony
2 participants