Fix socat service start failure

[ihor-sviziev]

After restarting php-fpm container on Ubuntu 20.04 we had missing ssh keys (computer restart, or just warden env restart), so we were getting the following issue during git clone via ssh:

Permission denied (public key).

In the logs of socat we found following line:

2021/02/19 08:08:26 socat[180] E "/tmp/ssh-auth.sock" exists

My PR removes socket file if it exists before starting socat.

Note: seems like we don't have this issue on Mac OS because there $SSH_AUTH_SOCK is equal to /run/host-services/ssh-auth.sock, and we're not starting socat here

Workaround

warden env down && warden env up

[ihor-sviziev]

One note - In my case I have correct permissions to the /run/host-services/ssh-auth.sock on Linux (if I use export SSH_AUTH_SOCK=/run/host-services/ssh-auth.sock - ssh works fine).
Maybe it's good to check if we have different user - only then start sockat, in other cases replace SSH_AUTH_SOCK?
Any thoughts?

[davidalger]

Very good find right here! The problem was easily reproduced, on both Mac and Linux hosts.

Maybe it's good to check if we have different user - only then start sockat, in other cases replace SSH_AUTH_SOCK?

It's a good thought, but would be difficult to implement due to the required change to SSH_AUTH_SOCK on the container environment if the permissions were ok. Let's go with the initially suggested fix here.