Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP-FPM and Varnish to use Centos8 Base Images #345

Merged
merged 8 commits into from
Apr 22, 2021
Merged

Conversation

davidalger
Copy link
Collaborator

  • Upstream PHP images are being updated to build atop a EL 8 vs EL 7: Add CentOS 8 images davidalger/docker-images-php#6
  • IUS repositories will no longer be present in upstream base images (as of this writing they were only used to install newer versions of Git and MariaDB which were not available in EL 7 repositories)
  • Git 2.27 is installed from EL 8 repositories vs Git 2.22 (git222 from IUS)
  • MariaDB 10.3 client is installed from EL 8 repositories vs MariaDB 10.2 client (mariadb102 from IUS)
  • The newer curl library in EL 8 will now allow constants for newer curl library features to be used in PHP code (see cURL version davidalger/docker-images-php#5 for details)

@davidalger davidalger self-assigned this Apr 12, 2021
images/varnish/4.1/Dockerfile Outdated Show resolved Hide resolved
images/varnish/6.0/Dockerfile Outdated Show resolved Hide resolved
images/varnish/6.4/Dockerfile Outdated Show resolved Hide resolved
images/varnish/6.5/Dockerfile Outdated Show resolved Hide resolved
@davidalger davidalger changed the title Update PHP-FPM with Centos8 Base Image Update PHP-FPM and Varnish to use Centos8 Base Images Apr 13, 2021
@davidalger
Copy link
Collaborator Author

davidalger commented Apr 13, 2021

Testing these has involved building the images from the upstream PR to provide EL8 base php images and then:

export PHP_VERSION=7.4
./images/scripts/build.sh php-fpm
./images/scripts/build.sh php-fpm/magento2
./images/scripts/build.sh varnish

Once the images are built locally, used a copy of this template to launch a Magneto 2 environment (without pulling during bootstrap to ensure locally built images are used):

warden bootstrap --clean-install --no-pull

After this completes, verify the application is working and operational in a browser, and verify /etc/os-release correctly report use of CentOS 8 vs CentOS 7.

@tdgroot
Copy link
Contributor

tdgroot commented Apr 21, 2021

LGTM, have been using this configuration for several weeks now!

@davidalger
Copy link
Collaborator Author

Now that the upstream php-fpm images are rebuilt on CentOS 8, I did a few things today to test this as well and everything appears to be A-ok.

In each case I double checked I was working with EL 8 images by running warden shell and then cat /etc/os-release

Going to get this merged as soon as I can write up a change log entry and upgrade notes regarding this given it is a rather larger change.

@davidalger davidalger merged commit 84f92d2 into develop Apr 22, 2021
@davidalger davidalger deleted the centos8 branch April 22, 2021 19:45
@davidalger davidalger added this to the Warden 0.11.0 milestone Apr 22, 2021
davidalger added a commit that referenced this pull request Apr 22, 2021
davidalger added a commit that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants