Environment and image build improvements #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ihor-sviziev Partially related to #285 |
ihor-sviziev
suggested changes
Jul 1, 2021
Signed-off-by: Denis Kopylov <dkopylov@magenius.team>
ihor-sviziev
approved these changes
Jul 5, 2021
|
@davidalger, could you review this PR? |
|
Merge commit 4daedec. Made a couple tweaks, to keep the docker.io prefix on the names, and use var name WARDEN_IMAGE_REPOSITORY vs WARDEN_SOURCE_REPOSITORY. |
|
Thanks for the efforts here! It's good flexibility to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is replace for #357
It would be great have ability to define repositories via CI variables or at warden
.envfiles.This PR provide improvements for image build and environment usage:
Ref. PR #345