Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify if docker-compose is available in proper version #41

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Verify if docker-compose is available in proper version #41

merged 2 commits into from
Nov 26, 2019
+12 −0

Conversation

lbajsarowicz
Copy link
Contributor

Feature: Add verification for docker-compose version (1.18.0 required at least, currently)

@lbajsarowicz
Copy link
Contributor Author

Issue related (I ran into the same issue) #11

➜  warden up
ERROR: The Compose file './docker/docker-compose.yml' is invalid because:
networks.default value Additional properties are not allowed ('name' was unexpected)
ERROR: Command `docker-compose -p warden -f docker/docker-compose.yml up -d "${WARDEN_PARAMS[@]}" "$@"` on line 23 failed with exit code 1

@lbajsarowicz lbajsarowicz force-pushed the feature/docker-compose-validation branch from f25a48b to 6e5da8d Compare November 21, 2019 19:33
davidalger
davidalger reviewed Nov 22, 2019
View reviewed changes
commands/install.cmd Outdated Show resolved Hide resolved
@lbajsarowicz @davidalger
Update commands/install.cmd
28af990 
Co-Authored-By: David Alger <davidmalger@gmail.com>
@davidalger davidalger merged commit c96824e into wardenenv:master Nov 26, 2019
davidalger added a commit that referenced this pull request Nov 26, 2019
@davidalger
Updated CL and version number in prep to publish #40 and #41 in v0.1.11
e2230db
@davidalger
Copy link
Collaborator

@lbajsarowicz This has been published in Warden 0.1.11. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidalger davidalger davidalger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lbajsarowicz @davidalger