Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes chromium browsers #84

Closed
sooswastaken opened this issue May 7, 2023 · 6 comments
Closed

Crashes chromium browsers #84

sooswastaken opened this issue May 7, 2023 · 6 comments

Comments

@sooswastaken
Copy link

image

The main gh page crashes chrome and arc, but not safari for me.

@sooswastaken
Copy link
Author

The script being in one line is insane

@tomleb3
Copy link
Collaborator

tomleb3 commented May 7, 2023

@sooswastaken Yes, ever since the inclusion of Preact and some new major features on top of that, it's an issue we've been dancing around.
While including Preact greatly improved the DX, the drawback is the output size.

@davidarroyo1234 What do you think about this?
Maybe it's time we re-visit the idea of turning it into an extension or a bookmarklet?
Or perhaps come up with some alternative way of presenting the script.

@sooswastaken
Copy link
Author

Making it a bookmarklet could probably work, they are just links right? I didn't realize that you guys were using an entire library lmfao.

If you guys decide to go the extension route, #21: I would love to see a feature where the current followers are saved to storage, and revisiting the extension could show changes in that data. The notification system might be too much tho.

@tomleb3
Copy link
Collaborator

tomleb3 commented May 7, 2023

I didn't realize that you guys were using an entire library lmfao.

Say what you will, but makes it a hell of a lot easier and more satisfying to work on than vanilla JS lol

If you guys decide to go the extension route, #21: I would love to see a feature where the current followers are saved to storage, and revisiting the extension could show changes in that data. The notification system might be too much tho.

Definitely feasible, even the notification system can potentially work with some cron job that runs at a specific time of day, but that complicates things and would require the user to fork the project and do some set-ups, etc...

However, we already do use storage for the whitelisting feature, so don't see the problem with enhancing it further to include some badge or even a dedicated "new" screen or tab.

I like that idea, but we probably should hold out on adding more stuff until we decide the right course of action in regards to the issue here.

@davidarroyo1234
Copy link
Owner

davidarroyo1234 commented May 8, 2023

image

The main gh page crashes chrome and arc, but not safari for me.

I mean its a big chunk of code but at the same time is not too big compared with other scripts that i have use previously. Could you provide you computer specs and chome version?

I dont like to much the extension idea because its "propietary". I could make the extension for offline installing and with this option would remain "open" source.

@tomleb3
Copy link
Collaborator

tomleb3 commented Jul 31, 2023

Not part of the readme anymore.
So this one is solved.

@tomleb3 tomleb3 closed this as completed Jul 31, 2023
@tomleb3 tomleb3 mentioned this issue Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants