Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow any AbstractArray for names in constructor #84

Closed
nalimilan opened this issue Feb 18, 2020 · 1 comment · Fixed by #85
Closed

Allow any AbstractArray for names in constructor #84

nalimilan opened this issue Feb 18, 2020 · 1 comment · Fixed by #85

Comments

@nalimilan
Copy link
Contributor

Do you think it would be possible to change this line to accept any AbstractArray? That would be useful in FreqTables to allow passing a CategoricalArray. Currently this makes our tests fail.

NamedArrays.jl/src/constructors.jl

Line 54 in e3bbb1a

names::Vector{VT}=[defaultnames(d) for d in size(array)],

@nalimilan nalimilan mentioned this issue Feb 18, 2020
Open
@nalimilan nalimilan mentioned this issue Feb 18, 2020
Merged
@nalimilan
Copy link
Contributor Author

Thanks! Actually it turned out more methods need the same change. I've filed #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change more constructors to accept AbstractVectors nalimilan/NamedArrays.jl
1 participant
@nalimilan