Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build scripts need attention #40

Open
davidbannon opened this issue Jul 8, 2023 · 2 comments
Open

Build scripts need attention #40

davidbannon opened this issue Jul 8, 2023 · 2 comments

Comments

@davidbannon
Copy link
Owner

David, you were half way through moving from individual deb/rpm scripts. the script package-lib needs work, in particular -

It does not correctly make the rpm package because the final part of version number is not being inserted into the spc file, we end up with a spec file containing "INSERT_EXTRAVER" and "INSERT_FULL_VER".

The rpm-package script, on the other hand, does not make a correct devel rpm file, it leaves the dev symlink with a stupid long path prepended to the target file name. package-lib does this properly !

This sure is a "can do better" !

David

@davidbannon
Copy link
Owner Author

Yes, using the individual script, rpm_package, the devel.rpm contains a symlink that is plainly wrong. Fixed and used to make 1.2.14 in release but I have not committed the fixed script yet. Need to workout whats going on with package-lib first. The package-lib script is, ultimately, the one to use and might have other content not present in the two individual ones. Further work needed....

@davidbannon
Copy link
Owner Author

OK, package-lib now seems to work as expected. Further, it now accepts a whatsnew file to populate the changelog (much like I do in tomboy-ng).
I'll wait until I have done some tests before closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant