Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parenthesize unary expressions of prefix operators #426

Closed

Conversation

devongovett
Copy link
Contributor

#315 didn't quite fix the issue fully. We also need to handle e.g. prefix update expressions inside a unary expression. ---i is invalid, but -(--i) is valid.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #426 (2daeda7) into master (6021bf0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   95.44%   95.43%   -0.01%     
==========================================
  Files           1        1              
  Lines        1119     1117       -2     
==========================================
- Hits         1068     1066       -2     
  Misses         51       51              
Impacted Files Coverage Δ
src/astring.js 95.43% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6021bf0...2daeda7. Read the comment docs.

@davidbonnet
Copy link
Owner

Thanks @devongovett for submitting this. 0b273a6 addresses this with less parentheses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants