Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chopping a ZIP file into fragments #3

Closed
BradKML opened this issue Mar 21, 2021 · 7 comments
Closed

chopping a ZIP file into fragments #3

BradKML opened this issue Mar 21, 2021 · 7 comments

Comments

@BradKML
Copy link

BradKML commented Mar 21, 2021

Since ZIP allow data splitting, take a look at https://kb.winzip.com/help/winzip/help_splitdlg.htm
Imagine a tweet thread with split files

@DavidBuchanan314
Copy link
Owner

This project should already work with split zip files.

@BradKML
Copy link
Author

BradKML commented Mar 21, 2021

Clarification on https://github.com/DavidBuchanan314/tweetable-polyglot-png#embedded-file-requirements
Sinde it does not hint at the use of the split function when creating the image, maybe I read that wrong.

@DavidBuchanan314
Copy link
Owner

Are you suggesting an update to the readme? How would you phrase it differently?

@BradKML
Copy link
Author

BradKML commented Mar 22, 2021

"If the embedded file is a .zip, then the offsets are automatically adjusted so that the overall file is still a valid zip."
This can be interpreted as a partial file, which does not quite make sense. Maybe:
"If the embedded file is a .zip, then it will be divided into partial zip files, each stored in a separate image."

@DavidBuchanan314
Copy link
Owner

Oh, that's not the current behavior. Zipping files is out-of-scope of this project, it just packs pre-zipped files. How those files are zipped is entirely up to the end-user.

@dardysing69
Copy link

dardysing69 commented Mar 22, 2021 via email

@dardysing69
Copy link

dardysing69 commented Mar 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants