Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sampling in C++ #19

Merged
merged 4 commits into from Mar 17, 2020
Merged

Implement sampling in C++ #19

merged 4 commits into from Mar 17, 2020

Conversation

davidchall
Copy link
Owner

Fixes #12

50-100x faster, 10x less memory allocated

50-100x faster, 10x less memory allocated
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #19 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   99.06%   99.16%   +0.10%     
==========================================
  Files          24       25       +1     
  Lines        1174     1198      +24     
==========================================
+ Hits         1163     1188      +25     
+ Misses         11       10       -1     
Impacted Files Coverage Δ
src/IpNetworkVector.h 100.00% <ø> (ø)
R/sample.R 95.65% <100.00%> (+0.65%) ⬆️
src/IpNetworkVector.cpp 100.00% <100.00%> (ø)
src/sample.h 100.00% <100.00%> (ø)
src/wrapper.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f9cf1...d1b9bde. Read the comment docs.

@davidchall davidchall merged commit ccdf640 into master Mar 17, 2020
@davidchall davidchall deleted the sample-cpp branch March 17, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement sample_ip in C++
1 participant