Skip to content

Commit

Permalink
Remove helper method to use content_for
Browse files Browse the repository at this point in the history
I think it's a better way to do this kind of stuff (build a header title
and put it elsewhere than in yield place)
  • Loading branch information
Yannick Francois committed Sep 26, 2013
1 parent 2cb2fb3 commit 0c38a45
Show file tree
Hide file tree
Showing 33 changed files with 737 additions and 696 deletions.
1 change: 1 addition & 0 deletions app/controllers/admin/feedback_controller.rb
Expand Up @@ -45,6 +45,7 @@ def index
end
@feedback = Feedback.where(conditions).order('feedback.created_at desc').page(params[:page]).per(this_blog.admin_display_elements)
end

def destroy
@record = Feedback.find params[:id]

Expand Down
12 changes: 0 additions & 12 deletions app/helpers/admin/base_helper.rb
Expand Up @@ -13,18 +13,6 @@ def subtabs_for(current_module)
output
end

def show_page_heading
return if @page_heading.nil? or @page_heading.blank?

unless @page_heading_class.nil? or @page_heading_class.blank?
@page_heading = content_tag(:i, "", class: "icon-large #{@page_heading_class}") + " " + @page_heading
end

content_tag(:div, {:class => 'page-header'}) do
content_tag(:h2, @page_heading.html_safe)
end
end

def cancel(url = {:action => 'index'})
link_to _("Cancel"), url, :class => 'btn'
end
Expand Down
7 changes: 4 additions & 3 deletions app/views/admin/cache/index.html.erb
@@ -1,5 +1,6 @@
<% @page_heading = _('Cache') %>
<% @page_heading_class = 'icon-settings'%>
<%- content_for :page_heading do %>
<h2 class="icon-large icon-settings"><%= _("Cache") %></h2>
<% end %>

<p><%= _("To save resources Publify caches content in static files. Cache is cleared each time something gets published. You may however want to clear the cache yourself.") %></p>

Expand All @@ -9,4 +10,4 @@
<div class='form-actions'>
<%= save( _("Sweep cache")) %>
</div>
<% end %>
<% end %>
52 changes: 27 additions & 25 deletions app/views/admin/categories/new.html.erb
@@ -1,21 +1,23 @@
<% @page_heading = _("Categories") %>
<% @page_heading_class = 'icon-categories'%>
<%- content_for :page_heading do %>
<h2 class="icon-large icon-categories"><%= _("Categories") %></h2>
<% end %>

<div>
<div class='span4'>
<%= form_tag :action=>"edit", :id => @category.id do %>
<%= error_messages_for 'category' %>
<label for='category_name'><%= _("Name") %></label>
<%= text_field :category, :name, :class => 'span12' %>
<label for='category_keywords' class='control-label'><%= _("Keywords") %></label>
<%= text_field :category, :keywords, :class => 'span12' %>
<label for="category_permalink"><%= _("Permalink") %></label>
<%= text_field :category, :permalink, :class => 'span12' %>
<p class='help-block'><%= _("Your category slug. Leave empty if you don't know what to put here") %></p>
<label for="category_description"><%= _("Description") %></label>
<%= text_area :category, :description, :rows => 5, :class => 'span12' %>
<div class='form-actions'>
<%= cancel_or_save %>
</div>
<%= error_messages_for 'category' %>
<label for='category_name'><%= _("Name") %></label>
<%= text_field :category, :name, :class => 'span12' %>
<label for='category_keywords' class='control-label'><%= _("Keywords") %></label>
<%= text_field :category, :keywords, :class => 'span12' %>
<label for="category_permalink"><%= _("Permalink") %></label>
<%= text_field :category, :permalink, :class => 'span12' %>
<p class='help-block'><%= _("Your category slug. Leave empty if you don't know what to put here") %></p>
<label for="category_description"><%= _("Description") %></label>
<%= text_area :category, :description, :rows => 5, :class => 'span12' %>
<div class='form-actions'>
<%= cancel_or_save %>
</div>
<% end %>
</div>

Expand All @@ -31,16 +33,16 @@
</thead>
<%= render_void_table(@categories.size, 4) %>
<% for category in @categories -%>
<tr id="category_<%= category.id -%>">
<td>
<%= link_to_edit category.name, category %>
<%= show_category_actions category %>
</td>
<td><%= h category.description %></td>
<td><%= category.permalink %></td>
<td><%= h category.keywords %></td>
</tr>
<tr id="category_<%= category.id -%>">
<td>
<%= link_to_edit category.name, category %>
<%= show_category_actions category %>
</td>
<td><%= h category.description %></td>
<td><%= category.permalink %></td>
<td><%= h category.keywords %></td>
</tr>
<% end -%>
</table>
</div>
</div>
</div>
92 changes: 49 additions & 43 deletions app/views/admin/content/index.html.erb
@@ -1,48 +1,54 @@
<% @page_heading = _('Manage articles') + content_tag(:div, link_to(_("New Article"), {:controller => 'content', :action => 'new'}, :id => 'dialog-link', :class => 'btn btn-info'), :class => 'pull-right') %>
<% @page_heading_class = 'icon-articles' %>
<%= form_remote_tag url: {action: 'index'}, method: :get, name: 'article', update: {:success => 'articleList'}, before: "Element.show('spinner')", complete: "Element.hide('spinner')" do %>
<%- content_for :page_heading do %>
<h2 class="icon-large icon-articles"><%= _("Manage articles") %></h2>
<div class="pull-right">
<%= link_to(_("New Article"), {controller: 'content', action: 'new'}, id: 'dialog-link', class: 'btn btn-info')%>
</div>

<% if params[:search] and params[:search]['state'] %>
<input type='hidden' name="search[state]" value="<%= params[:search]['state'] %>" >
<% end %>
<div>
<span class='badge badge-inverse'>
<%= link_to(_("All articles"), action: 'index') %>
</span>
<span class='badge badge-success'>
<%= link_to(_("Published"), action: 'index', search: {state: 'published'}) %>
</span>
<span class='badge badge-important'>
<%= link_to(_("Withdrawn"), action: 'index', search: {state: 'withdrawn'}) %>
</span>
<span class='badge badge-info'>
<%= link_to(_("Drafts"), action: 'index', search: {state: 'drafts'}) %>
</span>
<span class='badge badge-warning'>
<%= link_to(_("Publication pending"), action: 'index', search: {state: 'pending'}) %>
</span>
<div class='pull-right'>
<span class="input-append">
<input id="search" type="text" name="search[searchstring]" class='large' />
<%= submit_tag(_("Search"), {:class => 'btn'}) %>
<span id='spinner' style="display:none;"><%= image_tag('spinner.gif') %></span>
<%= form_remote_tag url: {action: 'index'}, method: :get, name: 'article', update: {:success => 'articleList'}, before: "Element.show('spinner')", complete: "Element.hide('spinner')" do %>
<% if params[:search] and params[:search]['state'] %>
<input type='hidden' name="search[state]" value="<%= params[:search]['state'] %>" >
<% end %>

<div>
<span class='badge badge-inverse'>
<%= link_to(_("All articles"), action: 'index') %>
</span>
<span class='badge badge-success'>
<%= link_to(_("Published"), action: 'index', search: {state: 'published'}) %>
</span>
<span class='badge badge-important'>
<%= link_to(_("Withdrawn"), action: 'index', search: {state: 'withdrawn'}) %>
</span>
<span class='badge badge-info'>
<%= link_to(_("Drafts"), action: 'index', search: {state: 'drafts'}) %>
</span>
<span class='badge badge-warning'>
<%= link_to(_("Publication pending"), action: 'index', search: {state: 'pending'}) %>
</span>
<div class='pull-right'>
<span class="input-append">
<input id="search" type="text" name="search[searchstring]" class='large' />
<%= submit_tag(_("Search"), {:class => 'btn'}) %>
<span id='spinner' style="display:none;"><%= image_tag('spinner.gif') %></span>
</span>
</div>
</div>
</div>
<br class='clearleft' />
<table class="table table-striped">
<thead>
<tr class='noborder'>
<th><%= _("Title") %></th>
<th><%= select_tag('search[category]', options_from_collection_for_select(Category.all, 'id', 'name'), {prompt: _("Select a category"), :class => 'span12'}) %></th>
<th><%= select_tag('search[user_id]', options_from_collection_for_select(User.all, 'id', 'name'), {prompt: _("Select an author"), :class => 'span12'}) %></th>
<th><%= select_tag('search[published_at]', options_for_select(Article.find_by_published_at), {prompt: _("Publication date"), :class => 'span12'}) %></th>
<th><input type="submit" value='<%= _("Filter") %>' class='btn' />
</tr>
</thead>
<tbody id="articleList">
<%= render 'article_list', { :articles => @articles } -%>
</tbody>
</table>
<%end%>
<br class='clearleft' />
<table class="table table-striped">
<thead>
<tr class='noborder'>
<th><%= _("Title") %></th>
<th><%= select_tag('search[category]', options_from_collection_for_select(Category.all, 'id', 'name'), {prompt: _("Select a category"), :class => 'span12'}) %></th>
<th><%= select_tag('search[user_id]', options_from_collection_for_select(User.all, 'id', 'name'), {prompt: _("Select an author"), :class => 'span12'}) %></th>
<th><%= select_tag('search[published_at]', options_for_select(Article.find_by_published_at), {prompt: _("Publication date"), :class => 'span12'}) %></th>
<th><input type="submit" value='<%= _("Filter") %>' class='btn' />
</tr>
</thead>
<tbody id="articleList">
<%= render 'article_list', { :articles => @articles } -%>
</tbody>
</table>
<%end%>
7 changes: 4 additions & 3 deletions app/views/admin/dashboard/index.html.erb
@@ -1,5 +1,6 @@
<% @page_heading = _("Welcome back, %s!", current_user.name ) %>
<% @page_heading_class = 'icon-dashboard'%>
<%- content_for :page_heading do %>
<h2 class="icon-large icon-dashboard"><%= _("Welcome back, %s!", current_user.name) %></h2>
<% end %>
<%= render "overview" %>

Expand All @@ -13,5 +14,5 @@
<%= render "drafts" %>
<%= render "inbound" %>
</div>

</div>
95 changes: 48 additions & 47 deletions app/views/admin/feedback/article.html.erb
@@ -1,63 +1,64 @@
<% @page_heading = _("Comments for %s", @article.title) %>
<% @page_heading_class = 'icon-comment' %>
<%- content_for :page_heading do %>
<h2 class="icon-large icon-comment"><%= _("Comments for %s", @article.title) %></h2>
<% end %>
<% @link_to_new = link_to(_("Add a comment"), '#comment', {:id => 'dialog-link', :class => 'button'}) %>
<%= form_tag({:action => 'bulkops'}) do %>
<%= hidden_field 'article_id', @article.id %>
<%= render 'button', { :position => 'top' } %>
<%= hidden_field 'article_id', @article.id %>
<%= render 'button', { :position => 'top' } %>

<br class='clear' />
<table class='table table-stripped'>
<thead>
<tr class='noborder'>
<th><input type="checkbox" name="checkall" id="checkall" onclick="check_all(this);"/></th>
<th><%= _("Status")%></th>
<th><%= _("Comment Author")%></th>
<th><%= _("Comment")%></th>
</tr>
</thead>
<%= render_void_table(@feedback.size, 5) %>
<br class='clear' />
<table class='table table-stripped'>
<thead>
<tr class='noborder'>
<th><input type="checkbox" name="checkall" id="checkall" onclick="check_all(this);"/></th>
<th><%= _("Status")%></th>
<th><%= _("Comment Author")%></th>
<th><%= _("Comment")%></th>
</tr>
</thead>
<%= render_void_table(@feedback.size, 5) %>
<% @feedback.each do |comment| %>
<%= render 'feedback', {:comment => comment} %>
<% end %>
</table>
<% @feedback.each do |comment| %>
<%= render 'feedback', {:comment => comment} %>
<% end %>
</table>
<%end%>
<%= form_tag :action => "create" do %>
<%= hidden_field_tag('article_id', @article.id) %>
<fieldset class='form-horizontal'>
<legend><%= _("Add a comment")%></legend>
<div class='control-group'>
<label for="comment_author" class='control-label'><%= _("Author")%></label>
<div class='controls'>
<%= text_field 'comment', 'author', :class => 'medium' %>
<%= hidden_field_tag('article_id', @article.id) %>
<fieldset class='form-horizontal'>
<legend><%= _("Add a comment")%></legend>
<div class='control-group'>
<label for="comment_author" class='control-label'><%= _("Author")%></label>
<div class='controls'>
<%= text_field 'comment', 'author', :class => 'medium' %>
</div>
</div>
<div class='control-group'>
<label for="comment_email" class='control-label'><%= _("Email")%></label>
<div class='controls'>
<%= text_field 'comment', 'email', :class => 'medium' %>
</div>
</div>
</div>
<div class='control-group'>
<label for="comment_email" class='control-label'><%= _("Email")%></label>
<div class='controls'>
<%= text_field 'comment', 'email', :class => 'medium' %>
<div class='control-group'>
<label for="comment_url" class='control-label'><%= _("Url") %></label>
<div class='controls'>
<%= text_field 'comment', 'url', :class => 'medium' %>
</div>
</div>
</div>
<div class='control-group'>
<label for="comment_url" class='control-label'><%= _("Url") %></label>
<div class='controls'>
<%= text_field 'comment', 'url', :class => 'medium' %>
<div class='control-group'>
<label for='comment_body' class='control-label'><%= _("Your comment") %></label>
<div class='controls'>
<script type="text/javascript">edToolbar('comment_body', '<%= current_user.default_text_filter.name %>');</script>
<%= text_area 'comment', 'body', { :rows => '10', :class => 'span6'} %>
</div>
</div>
</div>
<div class='control-group'>
<label for='comment_body' class='control-label'><%= _("Your comment") %></label>
<div class='controls'>
<script type="text/javascript">edToolbar('comment_body', '<%= current_user.default_text_filter.name %>');</script>
<%= text_area 'comment', 'body', { :rows => '10', :class => 'span6'} %>
<div class='form-actions'>
<%= cancel_or_save %>
</div>
</div>
<div class='form-actions'>
<%= cancel_or_save %>
</div>
</fieldset>
</fieldset>

<% end %>
17 changes: 9 additions & 8 deletions app/views/admin/feedback/edit.html.erb
@@ -1,14 +1,15 @@
<% @page_heading = _("Comments for %s", link_to(h(@comment.article.title), :controller => '/admin/content', :action => 'edit', :id => @comment.article.id).html_safe).html_safe %>
<% @page_heading_class = 'icon-comment' %>
<%- content_for :page_heading do %>
<h2 class="icon-large icon-comment"><%= _("Comments for %s", link_to(h(@comment.article.title), :controller => '/admin/content', :action => 'edit', :id => @comment.article.id).html_safe).html_safe %></h2>
<% end %>
<%= form_tag :action => "update", :id => @comment.id do %>
<%= error_messages_for 'comment' %>
<%= hidden_field_tag 'article_id', @article.id %>
<%= error_messages_for 'comment' %>
<%= hidden_field_tag 'article_id', @article.id %>

<fieldset class='form-horizontal'>
<div class='control-group'>
<label for="comment_author" class='control-label'><%= _("Author")%></label>
<fieldset class='form-horizontal'>
<div class='control-group'>
<label for="comment_author" class='control-label'><%= _("Author")%></label>
<div class='controls'>
<%= text_field 'comment', 'author', :class => 'span3' %>
</div>
Expand All @@ -35,6 +36,6 @@
<div class='form-actions'>
<%= cancel_or_save %>
</div>
</fieldset>
</fieldset>

<% end %>

0 comments on commit 0c38a45

Please sign in to comment.