-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bug/error when "MaxArea" is small. #16
Comments
I will defer to @davidcsterratt of course, but @shulele can you provide an example of the problem? I've run your code and checked and I see very clear results that the max triangle area is always under the threshold. |
@mdsumner The output figure is like this: Output of sessioninfo() is the following.
|
Ah, I definitely don't see that! Thanks for replying, I will explore. |
Thanks for the report. Unfortunately, I don't see this on my Linux (ubuntu) machine, and I don't have a Mac available to test on, so I'm a bit stuck and help will be appreciated.
|
I get the same. Sorry, blew up my fontconfig at some time.
$model_name $no_of_cores
Matrix products: default locale: attached base packages: other attached packages: loaded via a namespace (and not attached): I git cloned and R CMD INSTALL. Reading JR Shewchuk's code, papers, and Makefile, it seemed pretty clear that I should be making suggested adjustments in the build to de-fang Pentium floating point registers to enable/preserve the benefits of his exact geometry predicates. But I didn't compile it yet, installed RTriangle, copied and pasted @shulele 's code (to reassure me why I don't work on Mac), and then... Are you @davidcsterratt and Michael @mdsumner on AMD boxes? Or is my Pentium suggestion a red herring? |
triangulate(p, a = NULL, q = NULL, Y = FALSE, j = FALSE, setting S to a reasonable number greater than default, guessed at by looking at V =2 output * approximately 3, essentially giving steiner points additional elbow room to operate: tp <- triangulate(p, a=ia[i], S=90000)
So, even with changing triangle.c to #define LINUX and fiddling with interface.c to pull in ftu_control.h, got same results as @shulele, until adjusting Stiener. |
This is a perfect solution. Thank you, @chris-english . |
I noticed a bug or an error when I try to use small 'MaxArea' in the package.
I tested it with the following code:
Printed results are:
When the MaxArea is larger than 120, the results are correct.
When the MaxArea is less than 120, there are some triangles whose area is larger than the threshold.
The number of triangles should become more and more, along with the increasing MaxArea threshold.
I guess that is the issue from the size of 'int' in the code. But I cannot fix it yet.
Any thoughts or suggestions? Thank you.
The text was updated successfully, but these errors were encountered: