Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use theme #5

Closed
burbilog opened this issue Jul 31, 2016 · 5 comments
Closed

Can't use theme #5

burbilog opened this issue Jul 31, 2016 · 5 comments
Assignees
Labels

Comments

@burbilog
Copy link

burbilog commented Jul 31, 2016

Jekyll 3.2.0, ubuntu 16.04.1. I can't follow your instructions. First 3 steps are okay, but then there is no css/styles.scss file in css directory, only main.scss. Also there is no js/ directory at all. If I create these files, then I get bare site without theme. jekyll s --watch complains:

[2016-07-31 16:35:30] ERROR `/css/theme' not found.
[2016-07-31 16:35:33] ERROR `/css/theme' not found.
[2016-07-31 16:35:36] ERROR `/css/theme' not found.
@daviddarnes
Copy link
Owner

Are you using the demo code from the repo? There isn't a main.scss in there? You need to use the demo directory for reference, or the readme.md

@daviddarnes daviddarnes self-assigned this Jul 31, 2016
@burbilog
Copy link
Author

burbilog commented Jul 31, 2016

Heh, that was hard :) Finally I found the problem -- I created css/styles.css file, not scss. Tough to spot, it seems that brain filters out small difference. Thank you for pointing out to demo directory.

BTW, somehow your demo subdir works okay after git checkout wihout any modifications, but if I try to make a new directory from scratch with jekyll new I have to do several extra steps in addition to your instruction -- add gem "garth-jekyll-theme" to Gemfile and run bundle, otherwise adding theme: garth-jekyll-theme does not work:

jekyll 3.2.0 | Error:  The garth-jekyll-theme theme could not be found.

Also I have to remove css/main.scss file and remove some links from about.md.

@daviddarnes
Copy link
Owner

Hmm, just to check are you installing the theme properly using gem install garth-jekyll-theme theme?

Theming in Jekyll is in it's very early stages, so there are quite a few limitations to using it. This project is a proof of concept as well as an open source one 😄

@burbilog
Copy link
Author

burbilog commented Aug 1, 2016

Hmm, just to check are you installing the theme properly using gem install garth-jekyll-theme theme?

Yes.

I poked around and found that problem is caused by the very existence of Gemfile (jekyll new creates one by default). If I remove Gemfile then there is no need to add gem "garth-jekyll-theme" to it. That's why your demo directory works.

Theming in Jekyll is in it's very early stages, so there are quite a few limitations to using it. This project is a proof of concept as well as an open source one 😄

I remember playing with Jekyll several years ago and rejecting it because there was no theme changing, you had to stick with something from the beginning. Recently I saw something promising in 3.2.0, but still theming is not easy from user's point of view: I see no sense in messing with additional javascript and css files, etc if I apply standard packaged theme. Either these files must be installed automagically with some theme switch command (with previous theme's files purged to avoid various cryptic errors), or themes should not rely on any extra files in user directory at all (this would be the best solution).

@daviddarnes
Copy link
Owner

Ok, well I've removed some of the gem specific stuff. I'm hoping that means it won't kick up a fuss with the Gemfile.

I realise that Jekyll theming isn't up to scratch. However this is the very first iteration of it, so don't expect this version to have all the bells and whistles.

I'm going to close this as the theme is working, if the Gemfile is an issue I'll deal with it in another Issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants