Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features proposal #26

Closed
andreabusi opened this issue Apr 26, 2023 · 2 comments
Closed

New features proposal #26

andreabusi opened this issue Apr 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@andreabusi
Copy link
Contributor

Hi!
I'm working on some features for the theme. I want to share some changes that I made for my blog to discuss if could be useful also for the Gesko theme. Here is the list:

  1. Add comments-enable option to enable/disable Disqus comments. If false, the comments section is no longer visible
  2. Add more social channels (Linkedin, Mastodon) and show them in the social footer only if they are configured in the _config.yml file
  3. Migrate to FontAwesome v6.0 (to have some new icons, like the Mastodon one). This could be quite tricky because every user has to create a new Kit on the FontAwesome site

Could be these features interesting for the theme? If yes, I can create the PRs.

@DavideBri DavideBri added the enhancement New feature or request label Apr 27, 2023
@DavideBri
Copy link
Owner

DavideBri commented Apr 27, 2023

Sounds good! Sure make a PR! I'd love to make Gesko up to date!
I dont know about the FontAwesome v6 tho, maybe we can find another resource for the Mastodon logo?

@andreabusi
Copy link
Contributor Author

PR created with the proposed changes. Let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants