Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

second parameter for replaceInsertTags must be set to false #25

Open
fritzmg opened this issue Feb 21, 2017 · 2 comments
Open

second parameter for replaceInsertTags must be set to false #25

fritzmg opened this issue Feb 21, 2017 · 2 comments

Comments

@fritzmg
Copy link
Contributor

fritzmg commented Feb 21, 2017

This extension uses \Contao\Controller::replaceInsertTags(…) in various places. However, the second parameter is omitted - which defaults to true. If the second parameter is true, then insert tags like {{file::*}} (and many more) will not be replaced. This is of course not suitable for the purpose of this extension.

@fritzmg fritzmg changed the title second parameter for replaceInsertTags must be false second parameter for replaceInsertTags must be set to false Feb 21, 2017
@davidenke
Copy link
Owner

@fritzmg I know it's a very old issue: would you mind to pr?

@fritzmg
Copy link
Contributor Author

fritzmg commented Jul 5, 2017

Done. However as noted in the PR, that PR is untested, as I only reported this issue on behalf of a community forum user. I do not use the extension myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants