Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: macro calls may be underquoted #4

Closed
GoogleCodeExporter opened this issue Apr 11, 2015 · 4 comments
Closed

configure.ac: macro calls may be underquoted #4

GoogleCodeExporter opened this issue Apr 11, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

http://www.gnu.org/software/hello/manual/autoconf/Autoconf-Language.html

"""
Arguments should be enclosed within the quote characters ‘[’ and ‘]’, 
and be separated by commas.
"""

The page goes on to provide an example where quoting isn't require and goes on 
to say:

"""
Cautious Autoconf users would keep the quotes, but many Autoconf users find 
such precautions annoying...
"""

Personally, I am a cautious autoconf user, and wanted to bring this to your 
attention.

Original issue reported on code.google.com by endgame....@gmail.com on 22 Mar 2011 at 11:34

@GoogleCodeExporter
Copy link
Author

These are the calls to AC_CHECK_HEADERS(stdint.h stddef.h), 
AC_CHECK_FUNC(mmap), AC_SUBST([ac_cv_etc., and the four AC_SUBST() near the 
bottom, right? The m4_define, in particular, should stay as-is?

Original comment by sgunder...@bigfoot.com on 22 Mar 2011 at 11:39

@GoogleCodeExporter
Copy link
Author

Yes, but also the arguments to the AC_DEFINE calls. I'd quote the first 
argument to m4_define, because that's what the GNU M4 manual does: 
http://www.gnu.org/software/m4/manual/html_node/Define.html#Define

Note that autoconf changequotes to [] instead of `' for quotation.

Original comment by endgame....@gmail.com on 23 Mar 2011 at 12:13

@GoogleCodeExporter
Copy link
Author

Original comment by se...@google.com on 23 Mar 2011 at 1:08

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Fixed in r7.

Original comment by se...@google.com on 23 Mar 2011 at 11:13

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant