Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text escaping issue: lots of backslashes in confirmation email invite #25

Open
xenotropic opened this issue Apr 26, 2024 · 4 comments
Open

Comments

@xenotropic
Copy link

xenotropic commented Apr 26, 2024

I just did a test invite and at least Thunderbird I'm seeing lots of characters being escaped (double-escaped?) somehow; this breaks the URLs. The computer nerds would figure it out, but not the normal people. Any idea why this is happening?

image

@xenotropic xenotropic changed the title Text escaping issue: lots of \ Text escaping issue: lots of backslashes in confirmation email invite Apr 26, 2024
@xenotropic
Copy link
Author

Also the confirmation email subject lines seem to be URL encoded when they should not be

image

@davidfcarr
Copy link
Owner

I think I fixed the issue with HTML entities showing up in the subject line as shown above by switching to a WordPress specific function wp_specialchars_decode rather than a general PHP function. Not seeing the issue with backslashes. Can you provide an example of that?

@davidfcarr
Copy link
Owner

Sorry, what are you showing in the first screenshot? That looks like output from the ICS file attachment. I confess I haven't tested with Thunderbird, but I don't normally see that displayed. GMail would display it as a calendar invite.

@xenotropic
Copy link
Author

xenotropic commented May 1, 2024

That's a screenshot of Thunderbird showing the ics; you can also see where colons are getting escaped in the raw text of the ics (this is the ics file opened in gedit, text editor)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants