Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.6 and 3.3? #1016

Closed
hugovk opened this issue Jan 4, 2018 · 5 comments
Closed

Drop support for EOL Python 2.6 and 3.3? #1016

hugovk opened this issue Jan 4, 2018 · 5 comments

Comments

@hugovk
Copy link
Contributor

hugovk commented Jan 4, 2018

It looks like significant effort is going into maintaining support for EOL Python versions. When they reach EOL that means they're no longer receiving security updates.

image

https://en.wikipedia.org/wiki/CPython#Version_history

Here's the pip installs for jedi from PyPI for the last month (via pypinfo --percent --pip --markdown jedi pyversion).

python_version percent download_count
3.6 44.4% 155,231
3.5 27.5% 96,124
3.4 22.2% 77,788
2.7 5.2% 18,142
3.7 0.4% 1,559
3.3 0.2% 800
2.6 0.0% 30
3.2 0.0% 5

From these numbers, it looks like 2.6 and 3.3 can be safely dropped.

This would allow the code to be modernised and ease the maintenance burden quite a bit.

Thoughts?

@valignatev
Copy link

I would say that this is an absolutely beautiful idea. But I'm not that familiar with the Jedi source code, and I can't tell how this will simplify maintenance.

@hugovk
Copy link
Contributor Author

hugovk commented Jan 4, 2018

Some of the most recent commits have been to try and wrangle 2.6 and 3.3 into place (eg. e526cb1 and 6291568).

It would look something like #1017, and some more of https://github.com/adamchainz/flake8-comprehensions/blob/master/README.rst#examples are possible too.

@davidhalter
Copy link
Owner

I'm definitely dropping Python 2.6 in the release that contains the virtualenv branch. Probably not dropping 3.3 though. That's probably going to take another year or at least a few months.

Thanks for the research!

@hugovk
Copy link
Contributor Author

hugovk commented Jan 4, 2018

Sounds good. Of the two, there's definitely more benefit in dropping 2.6.

@davidhalter
Copy link
Owner

Closing this one in favor of #1018 and #1019. Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants