Refacto update

[GuillaumeCisco]

Big refactoring - Fix #36 #35 #29 #23 #2
Add className property for overriding loader style.
Fix scalibility pacman loader.
Load spinner like lodash do : import {BarLoader} from 'react-spinners or import BarLoader from 'react-spinners/BarLoader'

[davidhu2000]

Thanks @GuillaumeCisco, quick question, with the new updated import, does it allow both

import { Barloader } from 'react-spinners';
import BarLoader from 'react-spinners/BarLoader';

[GuillaumeCisco]

Yes

…

-- Guillaume Cisco Le sam. 14 juil. 2018 à 18:45, David Hu <notifications@github.com> a écrit :

Thanks @GuillaumeCisco <https://github.com/GuillaumeCisco>, quick question, with the new updated import, does it allow both import { Barloader } from 'react-spinners'; import BarLoader from 'react-spinners/BarLoader'; — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABGgrEOT96amTky2w7vzSPp37_hyaodMks5uGiAzgaJpZM4VHTDa> .

[davidhu2000]

@GuillaumeCisco looks like merging #34 caused a ton of merge conflicts.

#34 added a prop for loaderStyle, which I think is similar to what you are trying to do with className. I'm not sure which is better

[GuillaumeCisco]

@davidhu2000 Yes I saw something like this.
Using a new defined loaderStyle is over-killing. As we use emotion, the simplest and proper way is to stick with emotion api. Using className is easy, scalable, maintainable because it is a fundamental part of emotion.

Simply passing your css style overriding everything is far more easier and understandable without learning a new prop.

README should be updated too, in order to show a example.

[ludofischer]

Hi, I’m also interested in importing Spinners one at a time. Could we leave loaderStyle vs className aside for the moment and try to merge the file structure refactoring? I could prepare a new pull request based on this one but without touching loaderStyle.

[GuillaumeCisco]

@ludovicofischer @davidhu2000
I've just updated the code for solving conflicts and removing loaderStyle

[ludofischer]

Great! But technically the next release becomes breaking now. I don’t use loaderStyle so I don’t care and according to semver, when the major version is 0 anyone should expect breakage at any moment, but it could annoy someone out there. I guess @davidhu2000 can decide.

[GuillaumeCisco]

@ludovicofischer , yes absolutely.

[davidhu2000]

This is definitely at least a minor version bump, may have to deprecate 0.3.3

[davidhu2000]

👍