Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for React 18 > #516

Closed
bearsworth opened this issue May 23, 2022 · 3 comments
Closed

Allow for React 18 > #516

bearsworth opened this issue May 23, 2022 · 3 comments

Comments

@bearsworth
Copy link

Is your feature request related to a problem? Please describe.
I believe this package won't work for React 18 and greater. Here is the issue:

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0 || ^17.0.0" from react-spinners@0.11.0
npm ERR! node_modules/react-spinners
npm ERR! react-spinners@"^0.11.0" from the root project

Describe the solution you'd like
If possible, allow for React 18, this is a great and easy to use spinner. Would love to be able to use it in newer projects.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@bearsworth
Copy link
Author

I have used --legacy-peer-deps which seems to work.

@davidhu2000
Copy link
Owner

@bearsworth please update to 0.12.0 which includes react 18 support

@bearsworth
Copy link
Author

@davidhu2000 Thanks for that and thanks for this awesome package man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants