Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font-size 0 breaks em CSS unit sizing for Pacman loader #571

Open
sdemjanenko opened this issue Sep 1, 2023 · 0 comments
Open

Font-size 0 breaks em CSS unit sizing for Pacman loader #571

sdemjanenko opened this issue Sep 1, 2023 · 0 comments

Comments

@sdemjanenko
Copy link

Package Version
0.13.8

I'm trying to size the PacmanLoader using CSS units of em. When I do this, I observe the spinner has no height because font-size is set to 0. This is coming from

const wrapper: React.CSSProperties = {
    display: "inherit",
    position: "relative",
    fontSize: 0,
    height: `${value * 2}${unit}`,
    width: `${value * 2}${unit}`,
    ...cssOverride,
  };

I am planning on using cssOverride, but it would be nice if the library automatically detected the em units and didn't set font-size of 0 in that case.

This is the CSS that I observe on the span that contains the spinner
image

I also haven't checked if other loaders suffer from the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant