Fixing disconnect when iframe is missing temporarly #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhicken
force-pushed
the
fix-missing-dom-on-readd
branch
from
05e961b
to
5d6a22d
Compare
|
also im not sure what to fix for coveralls |
|
also added a fix for destroying iframe resizer when the iframe is not in the dom |
|
Sorry for the delay, merged into v3.5.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine you have an iFrame on the page its been initialized with iframe-resizer.
You then want to move it to a cache somewhere and put it back at a later point. Without this fix. Iframe-resizer will throw an error...
Here is kinda what happens.
You have already initialized the iframe. However when Iframe-resizer noticed the iframe was not in the DOM (usually on focus). It deleted it from the list of registered iframes. Once the DOM node is reinserted iframe-resizer cannot find it due to it being removed from the list of registered iframes.
The fix seems pretty simple. The tests pass with it. So... I don't think I'm missing any thing mission critial.