Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearFix related options #427

Closed
giovdk21 opened this issue Nov 9, 2016 · 1 comment
Closed

clearFix related options #427

giovdk21 opened this issue Nov 9, 2016 · 1 comment

Comments

@giovdk21
Copy link

giovdk21 commented Nov 9, 2016

Hello,
from the changelog:

Inject clearFix into 'body' to work around CSS floats preventing the height being correctly calculated.

As far as I can see now injectClearFixIntoBodyElement is called regardless and there is no option to customise it / not have it.

For example, when using taggedElement, couldn't the clearFix div also have the data-iframe-height attribute?

Or if for some reason I have my own element having data-iframe-height that already have the "clear" style applied to it, then the clearFix would not needed.

Another edge case would be if for some (evil) reason there was a global style setting a margin or min-height to all divs, then the clearFix one may end up creating an extra space at the bottom.

I hope this makes sense. My suggestion would be to have a "injectClearFix" option set to true by default and a "useClearFixAsTaggedElement" set to false by default.

Thanks

@davidjbradshaw
Copy link
Owner

Hi,

I try no to have too many options as it makes things to complicated for people. I've never seen a real world issue where this has created a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants