You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Inject clearFix into 'body' to work around CSS floats preventing the height being correctly calculated.
As far as I can see now injectClearFixIntoBodyElement is called regardless and there is no option to customise it / not have it.
For example, when using taggedElement, couldn't the clearFix div also have the data-iframe-height attribute?
Or if for some reason I have my own element having data-iframe-height that already have the "clear" style applied to it, then the clearFix would not needed.
Another edge case would be if for some (evil) reason there was a global style setting a margin or min-height to all divs, then the clearFix one may end up creating an extra space at the bottom.
I hope this makes sense. My suggestion would be to have a "injectClearFix" option set to true by default and a "useClearFixAsTaggedElement" set to false by default.
Thanks
The text was updated successfully, but these errors were encountered:
Hello,
from the changelog:
As far as I can see now injectClearFixIntoBodyElement is called regardless and there is no option to customise it / not have it.
For example, when using taggedElement, couldn't the clearFix div also have the data-iframe-height attribute?
Or if for some reason I have my own element having data-iframe-height that already have the "clear" style applied to it, then the clearFix would not needed.
Another edge case would be if for some (evil) reason there was a global style setting a margin or min-height to all divs, then the clearFix one may end up creating an extra space at the bottom.
I hope this makes sense. My suggestion would be to have a "injectClearFix" option set to true by default and a "useClearFixAsTaggedElement" set to false by default.
Thanks
The text was updated successfully, but these errors were encountered: