Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property 'firstRun' of undefined #498

Closed
shaunjohansen opened this issue Jun 27, 2017 · 2 comments
Closed

TypeError: Cannot read property 'firstRun' of undefined #498

shaunjohansen opened this issue Jun 27, 2017 · 2 comments
Labels

Comments

@shaunjohansen
Copy link
Contributor

We are intermittently seeing this error in our logs using v3.5.14. It has been seen on desktop Chrome, iOS and Android.

I have tracked it down to the settings[iframeId].firstRun in this function:

		function checkReset(){
			// Reduce scope of firstRun to function, because IE8's JS execution
			// context stack is borked and this value gets externally
			// changed midway through running this function!!!
			var
				firstRun           = settings[iframeId].firstRun,
				resetRequertMethod = settings[iframeId].heightCalculationMethod in resetRequiredMethods;

			if (!firstRun && resetRequertMethod){
				resetIFrame({iframe:iframe, height:0, width:0, type:'init'});
			}
		}

@shaunjohansen
Copy link
Contributor Author

Offering up a pull request to address the issue: #499

@davidjbradshaw
Copy link
Owner

Fix r3.5.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants