Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening the context menu while dragging mouseup is not being triggered #37

Closed
mrksmts opened this issue Dec 3, 2019 · 4 comments
Closed
Labels
bug Something isn't working resolved This issue is resolved

Comments

@mrksmts
Copy link

mrksmts commented Dec 3, 2019

It is an edge case:

When you right click while dragging and open the context menu and then release both mouse buttons the mouseup is not being triggered so you keep dragging till you click forcing a mousedown/up.

@davidjerleke
Copy link
Owner

davidjerleke commented Dec 3, 2019

Hello Mark (@mrksmts),

Nice catch! Thank you for reporting this 👍.
Embla should listen for the contextmenu event and act on it. I will look into this and get back to you when I have something.

Best,
David

@davidjerleke davidjerleke added bug Something isn't working investigating Issue is being looked into labels Dec 3, 2019
@davidjerleke
Copy link
Owner

davidjerleke commented Dec 5, 2019

Hi Mark (@mrksmts),

Patch Release v2.6.4 should solve this issue. This issue also made me aware of that Embla listens for drag events even if the clicked mouse button isn't the left button. This is not intended and I've fixed that too. So thanks a lot 👍!

I'd very much appreciate if you could confirm if the patch is working as intended.

Cheers!
David

@davidjerleke davidjerleke added awaiting response Issue is awaiting feedback and removed investigating Issue is being looked into labels Dec 5, 2019
@mrksmts
Copy link
Author

mrksmts commented Dec 6, 2019

Hi David (@davidcetinkaya),

Works like a charm!
Thanks a lot for fixing this so quickly!

Best,
Mark

@mrksmts mrksmts closed this as completed Dec 6, 2019
@davidjerleke
Copy link
Owner

@mrksmts thanks for getting back to me 👍. I'm glad to hear that it works.

Have a nice one!
David

@davidjerleke davidjerleke removed the awaiting response Issue is awaiting feedback label Dec 6, 2019
@davidjerleke davidjerleke added the resolved This issue is resolved label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved This issue is resolved
Projects
None yet
Development

No branches or pull requests

2 participants