Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel transition animation broken on Firefox (117) #568

Closed
1 task done
Tracked by #321
hamidrezahanafi opened this issue Sep 18, 2023 · 6 comments
Closed
1 task done
Tracked by #321

Carousel transition animation broken on Firefox (117) #568

hamidrezahanafi opened this issue Sep 18, 2023 · 6 comments
Labels
bug Something isn't working resolved This issue is resolved

Comments

@hamidrezahanafi
Copy link
Contributor

hamidrezahanafi commented Sep 18, 2023

Bug is related to

  • embla-carousel (core package)

Embla Carousel version

  • v8.0.0.rc12

Describe the bug

Carousel transition animation broken on Firefox (117)
Better describe it in a video

Screen.Recording.2023-09-18.at.3.08.06.PM.mov

CodeSandbox

https://codesandbox.io/s/y6vw87

Steps to reproduce

  1. Go to 'Code sandbox on firefox (latest version 117)
  2. Click on Next/Previous and first few transition animations are broken

Expected behavior

Smooth animations

@hamidrezahanafi hamidrezahanafi added the bug Something isn't working label Sep 18, 2023
@davidjerleke
Copy link
Owner

davidjerleke commented Sep 19, 2023

Hi @hamidrezahanafi,

Thank you for your bug report. I just tested this on Firefox 117.0.1 (64-bit), Mac (OSX) and couldn't reproduce the problem. What device and OS are you using?

Best,
David

@hamidrezahanafi
Copy link
Contributor Author

Hey @davidjerleke I use a 16inch m1pro Mac.
I can reproduce it on my external monitor and if I reduce the Firefox window size on Mac
Check the video

Screen.Recording.2023-09-19.at.8.17.29.AM.mov

@davidjerleke
Copy link
Owner

Thanks @hamidrezahanafi 👍, I can reproduce it now. I'll investigate it when possible.

@davidjerleke
Copy link
Owner

davidjerleke commented Sep 19, 2023

Hi @hamidrezahanafi,

I've investigated this now and it seems like this was caused by the same problem as you discovered here:

Looping slides (translating them to achieve the effect) was triggering a resize which in turn was causing Embla to run reInit() and hard resetting the carousel - hence the instant transition. I just released v8.0.0-rc14 and can't reproduce this problem now. Please try the latest version and see if this problem is solved.

Best,
David

@davidjerleke davidjerleke added the awaiting response Issue is awaiting feedback label Sep 19, 2023
@hamidrezahanafi
Copy link
Contributor Author

Yes tested and it's fixed on FF now. Thanks

@davidjerleke
Copy link
Owner

@hamidrezahanafi thank you for finding the bug and explaining it well 🎉!

@davidjerleke davidjerleke added resolved This issue is resolved and removed awaiting response Issue is awaiting feedback labels Sep 19, 2023
This was referenced Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved This issue is resolved
Projects
None yet
Development

No branches or pull requests

2 participants