Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus interaction to autoplay #616

Closed
1 task done
davidjerleke opened this issue Nov 2, 2023 · 0 comments · Fixed by #615
Closed
1 task done

Add focus interaction to autoplay #616

davidjerleke opened this issue Nov 2, 2023 · 0 comments · Fixed by #615
Labels
feature request New feature or request resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

davidjerleke commented Nov 2, 2023 •
edited

👉 Credit goes to @nwidynski.

Feature request is related to

  • embla-carousel-autoplay

Is your feature request related to an issue?

  • The current implementation of stopOnInteraction does not stop if focus is received by a nested element.

Describe the solution you'd like

  • Add event handlers to the autoplay plugin to stop the autoplay if a bubbled up focus event is received by the root element.
@davidjerleke davidjerleke added the feature request New feature or request label Nov 2, 2023
@davidjerleke davidjerleke linked a pull request Nov 2, 2023 that will close this issue
Add focus interaction to autoplay #615
Merged
1 task
@davidjerleke davidjerleke mentioned this issue Nov 2, 2023
Closed
37 tasks
@davidjerleke davidjerleke added the resolved This issue is resolved label Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request resolved This issue is resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add focus interaction to autoplay
1 participant
@davidjerleke