Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reading element dimensions work regardless of transforms #637

Closed
1 task done
Tracked by #321
davidjerleke opened this issue Nov 25, 2023 · 0 comments · Fixed by #633
Closed
1 task done
Tracked by #321

Make reading element dimensions work regardless of transforms #637

davidjerleke opened this issue Nov 25, 2023 · 0 comments · Fixed by #633
Labels
core This is related to the core package feature request New feature or request resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

davidjerleke commented Nov 25, 2023

Feature request is related to

  • embla-carousel (core package)

Is your feature request related to an issue?

Originally posted by javiergonzalezGenially
When using the carousel inside a container with a scale transform applied the carousel doesn't work properly because it uses to measure nodes getBoundingClientRect, which returns a rect which is already scaled.

Describe the solution you'd like

Originally posted by javiergonzalezGenially
The proposed fix (tested working in the playground) uses instead offsetLeft/offsetWidth etc, which are unscaled.

@davidjerleke davidjerleke added the feature request New feature or request label Nov 25, 2023
@davidjerleke davidjerleke added the core This is related to the core package label Nov 27, 2023
@davidjerleke davidjerleke added the resolved This issue is resolved label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This is related to the core package feature request New feature or request resolved This issue is resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant