Skip to content
This repository has been archived by the owner on Aug 23, 2022. It is now read-only.

Control.text not setting input type #551

Closed
sl33kr opened this issue Dec 1, 2016 · 3 comments
Closed

Control.text not setting input type #551

sl33kr opened this issue Dec 1, 2016 · 3 comments

Comments

@sl33kr
Copy link
Contributor

sl33kr commented Dec 1, 2016

Hi,
Just started using this as an alternative to redux-form as we like the seperation between form state and model state.

We have come across an issue though, it would see that Control.text isn't setting the correct input type.

Don't know if this is deliberate or a bug?

https://github.com/davidkpiano/react-redux-form/blob/master/src/components/control-component.js#L633

@davidkpiano
Copy link
Owner

Not deliberate, although according to the W3 spec, the default type for <input /> without a type="..." attribute is "text". I went ahead and made it explicit though, and it should go out in the next release!

@sl33kr
Copy link
Contributor Author

sl33kr commented Dec 2, 2016

Thanks David!

This was messing with some styling coming from an external library we use.

@davidkpiano
Copy link
Owner

davidkpiano commented Dec 2, 2016

You're welcome! This will go out tomorrow. If you need it today, you can add it manually:

<Control.text
  controlProps={{type: 'text'}}
  model="..."
  // etc.
/>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants