machine.resolveState(state) calls should resolve to the correct val…

…ue of `.done` property now (#1816)
statelyai · Jan 6, 2021 · 0cb8df9 · 0cb8df9
1 parent 07980da
commit 0cb8df9
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/.changeset/quick-pets-collect.md b/.changeset/quick-pets-collect.md
@@ -0,0 +1,5 @@
+---
+'xstate': patch
+---
+
+`machine.resolveState(state)` calls should resolve to the correct value of `.done` property now.
diff --git a/packages/core/src/StateNode.ts b/packages/core/src/StateNode.ts
@@ -692,7 +692,8 @@ class StateNode<
     return new State({
       ...state,
       value: this.resolve(state.value),
-      configuration
+      configuration,
+      done: isInFinalState(configuration, this)
     });
   }
 

diff --git a/packages/core/test/machine.test.ts b/packages/core/test/machine.test.ts
@@ -1,4 +1,4 @@
-import { Machine, interpret } from '../src/index';
+import { Machine, interpret, createMachine } from '../src/index';
 import { State } from '../src/State';
 
 const pedestrianStates = {
@@ -282,6 +282,25 @@ describe('machine', () => {
 
       expect(resolvedState.nextEvents.sort()).toEqual(['TO_BAR', 'TO_TWO']);
     });
+
+    it('should resolve .done', () => {
+      const machine = createMachine({
+        initial: 'foo',
+        states: {
+          foo: {
+            on: { NEXT: 'bar' }
+          },
+          bar: {
+            type: 'final'
+          }
+        }
+      });
+      const tempState = State.from<any>('bar');
+
+      const resolvedState = machine.resolveState(tempState);
+
+      expect(resolvedState.done).toBe(true);
+    });
   });
 
   describe('versioning', () => {