Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with data expressions of root's final nodes being called twice #1085

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Mar 19, 2020

fixes #1079 , cc @RafalFilipek

This shouldnt be a breking change as this incorrecty generated done event had no chance to be caught by the machine (as it has reached the final state it has stopped by then and ignores all events)

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2020

🦋 Changeset is good to go

Latest commit: e88aa18

We got this.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e88aa18:

Sandbox Source
zen-rgb-0i9mn Configuration
modest-firefly-y0wv7 Configuration
determined-brook-pwpr9 Issue #1079

@davidkpiano davidkpiano merged commit e64a368 into master Mar 19, 2020
@davidkpiano davidkpiano deleted the fix/root-final-nodes branch March 19, 2020 23:11
@github-actions github-actions bot mentioned this pull request Mar 19, 2020
@github-actions github-actions bot mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data function is executed before machine enters final state.
2 participants