Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolution to never for state.matches(...) #1189

Merged
merged 3 commits into from
May 18, 2020
Merged

Fix resolution to never for state.matches(...) #1189

merged 3 commits into from
May 18, 2020

Conversation

davidkpiano
Copy link
Member

Closes #947

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2020 •
edited
Loading

🦋 Changeset is good to go

Latest commit: 4f90639

We got this.

This PR includes changesets to release 7 packages
Name Type
xstate Minor
@xstate/analytics Major
@xstate/graph Major
@xstate/immer Major
@xstate/react Major
@xstate/test Major
@xstate/vue Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidkpiano davidkpiano requested a review from Andarist May 16, 2020 20:54
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 16, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f90639:

Sandbox Source
broken-hill-5yij5 Configuration
charming-brook-mc86d Configuration
suspicious-lalande-e0s3d Issue #947

Andarist
Andarist approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever use of conditional type as a type argument 👍

@davidkpiano davidkpiano merged commit 79f2070 into master May 18, 2020
@davidkpiano davidkpiano deleted the davidkpiano/947 branch May 18, 2020 22:53
@github-actions github-actions bot mentioned this pull request May 18, 2020
Merged
@davidkpiano davidkpiano mentioned this pull request May 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andarist Andarist Andarist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@xstate/react: typescript: state is always never after calling .matches() twice in the same expression
2 participants
@davidkpiano @Andarist