Ensure exit actions are called for finalized invoked machines. Fixes #1109 #1566
Conversation
🦋 Changeset detectedLatest commit: dd591ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidkpiano
changed the title
| @@ -275,6 +275,13 @@ export class Interpreter< | |||
| const isDone = isInFinalState(state.configuration || [], this.machine); | |||
|
|
|||
| if (this.state.configuration && isDone) { | |||
| // exit interpreter procedure: https://www.w3.org/TR/scxml/#exitInterpreter | |||
| this.state.configuration.forEach((stateNode) => { | |||
There was a problem hiding this comment.
Those exit handlers should be executed in "exit order". I'm not sure if this.state.configuration holds any guarantee about the order of items in it. It would actually be quite cool to rely on it without having to sort stuff here, I'm just not sure if we can safely make such an assumption now.
There was a problem hiding this comment.
In the next branch, I believe these are sorted by exit order (I think there are some SCXML tests ensuring this). I'll see what I can do here to have the same behavior.
There was a problem hiding this comment.
The only SCXML I could find regarding this is: https://www.w3.org/Voice/2013/scxml-irp/250/test250.txml and it's classified as manual (it's one of the tests that requires the tester to look at the log output)
There was a problem hiding this comment.
This would be better suited for the next branch, since that more faithfully follows the SCXML algorithm. There would probably need to be substantial changes in order to ensure exit action order; let's scope this PR to just ensuring that they are called.
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
This PR fixes #1109 by executing exit actions when an invoked machine reaches its final state.