Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: restrict invoked Subscribable to EventObject #2107

Conversation

woutermont
Copy link
Contributor

Adds feature from #2106.

Signed-off-by: Wouter Termont woutermont@gmail.com

BREAKING

Signed-off-by: Wouter Termont <woutermont@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2021

🦋 Changeset detected

Latest commit: 9e5ac11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@woutermont
Copy link
Contributor Author

Voila, some pragmatism and an updated description ... ready for merging.

@VanTanev
Copy link
Contributor

This should be coordinated with #2125. It seems to me that Subscribable should use TEvent, which as defined in that PR is TEvent extends EventObject = AnyEventObject

@VanTanev
Copy link
Contributor

@Andarist Should I incorporate this PR into #2125 ?

@davidkpiano davidkpiano merged commit d6c3568 into statelyai:master May 8, 2021
This was referenced May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants