Deprecate useService() #2286
Merged
Deprecate useService() #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a0deb5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
reviewed
Jun 14, 2021
Andarist
reviewed
Jun 14, 2021
| @@ -126,7 +132,7 @@ A [React hook](https://reactjs.org/hooks) that subscribes to state changes from | |||
| - `state` - Represents the current state of the service as an XState `State` object. | |||
| - `send` - A function that sends events to the running service. | |||
|
|
|||
| ### `useActor(actor, getSnapshot)` | |||
| ### `useActor(actor, getSnapshot?)` | |||
There was a problem hiding this comment.
q: should we support getSnapshot in the future? or should we just expect that actor.getSnapshot is available?
There was a problem hiding this comment.
We should not (but this is a major breaking change). We should expect .getSnapshot to be available.
Andarist
reviewed
Jun 14, 2021
Andarist
reviewed
Jun 14, 2021
Andarist
reviewed
Jun 14, 2021
Andarist
reviewed
Jun 18, 2021
| @@ -137,7 +137,7 @@ describe('useService hook', () => { | |||
| expect(countEl.textContent).toBe('1'); | |||
| }); | |||
|
|
|||
| it('should throw if provided an actor instead of a service', (done) => { | |||
| it.skip('should throw if provided an actor instead of a service', (done) => { | |||
There was a problem hiding this comment.
this can be unskipped now, right?
Andarist
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
.getSnapshot(), theuseService()hooks are virtually the same asuseActor().